luyadev/luya

View on GitHub
core/web/UrlManager.php

Summary

Maintainability
A
2 hrs
Test Coverage
B
88%

Method parseRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parseRequest($request)
    {
        // extra data from request to composition, which changes the pathInfo of the Request-Object.
        $resolver = $this->getComposition()->getResolvedPathInfo($request);

Severity: Minor
Found in core/web/UrlManager.php - About 1 hr to fix

    Function urlReplaceModule has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function urlReplaceModule($url, $navItemId, Composition $composition)
        {
            $route = $composition->removeFrom($this->removeBaseUrl($url));
            $moduleName = $this->findModuleInRoute($route);
        
    Severity: Minor
    Found in core/web/UrlManager.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parseRequest($request)
        {
            // extra data from request to composition, which changes the pathInfo of the Request-Object.
            $resolver = $this->getComposition()->getResolvedPathInfo($request);
    
    
    Severity: Minor
    Found in core/web/UrlManager.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addRules has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function addRules($rules, $append = true)
        {
            foreach ($rules as $key => $rule) {
                if (is_array($rule) && isset($rule['composition'])) {
                    foreach ($rule['composition'] as $composition => $pattern) {
    Severity: Minor
    Found in core/web/UrlManager.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status