luyadev/luya

View on GitHub

Showing 91 of 91 total issues

Method actionClone has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionClone($vendor = null, $repo = null)
    {
        // if `vendor/repo` notation is provided
        if ($vendor !== null && strpos($vendor, '/')) {
            list($vendor, $repo) = explode("/", $vendor);
Severity: Minor
Found in dev/RepoController.php - About 1 hr to fix

    Function getViewPath has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getViewPath()
        {
            if ($this->module instanceof Module) {
                if ($this->module->useAppViewPath) {
                    return '@app/views/' . $this->module->id . '/' . $this->id;
    Severity: Minor
    Found in core/web/Controller.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function actionCreate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionCreate(string $themeName = null)
        {
            Console::clearScreenBeforeCursor();
            
            $themeName = $this->prompt("Enter the name (lower case) of the theme you like to generate:", ['default' => $themeName]);
    Severity: Minor
    Found in core/console/commands/ThemeController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!Object.isSealed) {
            Object.isSealed = function isSealed(object) {
                if (Object(object) !== object) {
                    throw new TypeError('Object.isSealed can only be called on Objects.');
                }
    core/resources/lazyload/intersectionObserver.polyfill.src.js on lines 546..553

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!Object.isFrozen) {
            Object.isFrozen = function isFrozen(object) {
                if (Object(object) !== object) {
                    throw new TypeError('Object.isFrozen can only be called on Objects.');
                }
    core/resources/lazyload/intersectionObserver.polyfill.src.js on lines 535..542

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _checkForIntersections has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        IntersectionObserver.prototype._checkForIntersections = function() {
          if (!this.root && crossOriginUpdater && !crossOriginRect) {
            // Cross origin monitoring, but no initial data available yet.
            return;
          }
    Severity: Minor
    Found in core/resources/lazyload/intersectionObserver.polyfill.src.js - About 1 hr to fix

      Function _unmonitorIntersections has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          IntersectionObserver.prototype._unmonitorIntersections = function(doc) {
            var index = this._monitoringDocuments.indexOf(doc);
            if (index == -1) {
              return;
            }
      Severity: Minor
      Found in core/resources/lazyload/intersectionObserver.polyfill.src.js - About 1 hr to fix

        Function getConfigArray has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getConfigArray()
            {
                if ($this->_configArray === null) {
                    if (!file_exists($this->configFile)) {
                        if (!$this->getIsCli()) {
        Severity: Minor
        Found in core/base/Boot.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function smtpTest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function smtpTest($verbose)
            {
                //Create a new SMTP instance
                $smtp = new SMTP();
                
        Severity: Minor
        Found in core/components/Mail.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loadThemeConfig has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function loadThemeConfig(string $basePath)
            {
                if (strpos($basePath, '@') === 0) {
                    $dir = Yii::getAlias($basePath);
                } elseif (strpos($basePath, '/') === 0) {
        Severity: Minor
        Found in core/theme/ThemeManager.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function run($app)
            {
                if (!$app->request->getIsConsoleRequest()) {
                    if ($this->hasModule('admin') && $app->request->isAdmin) {
                        // When admin context, change csrf token, this will not terminate the frontend csrf token:
        Severity: Minor
        Found in core/web/Bootstrap.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getThemeDefinitions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getThemeDefinitions()
            {
                $themeDefinitions = [];
                
                if (file_exists(Yii::getAlias('@app/themes'))) {
        Severity: Minor
        Found in core/theme/ThemeManager.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method applicationConsole has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function applicationConsole()
            {
                $this->setIsCli(true);
                $config = $this->getConfigArray();
                $config['defaultRoute'] = 'help';
        Severity: Minor
        Found in core/base/Boot.php - About 1 hr to fix

          Method behaviors has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function behaviors()
              {
                  $behaviors = parent::behaviors();
          
                  if ($this->enableCors) {
          Severity: Minor
          Found in core/traits/RestBehaviorsTrait.php - About 1 hr to fix

            Method generateClassName has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function generateClassName($tableName, $useSchemaName = null)
                {
                    if (isset($this->classNames[$tableName])) {
                        return $this->classNames[$tableName];
                    }
            Severity: Minor
            Found in core/console/commands/BaseCrudController.php - About 1 hr to fix

              Function toArray has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function toArray($envs = [])
                  {
                      $config = [];
                      $envs = (array) $envs;
                      $envs = array_merge($envs, [self::ENV_ALL]);
              Severity: Minor
              Found in core/Config.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getDirectoryFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getDirectoryFiles($folderName)
                  {
                      $files = [];
                      if (array_key_exists($folderName, $this->_dirs)) {
                          foreach ($this->_dirs[$folderName] as $folder) {
              Severity: Minor
              Found in core/console/commands/ImportController.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method parseRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function parseRequest($request)
                  {
                      // extra data from request to composition, which changes the pathInfo of the Request-Object.
                      $resolver = $this->getComposition()->getResolvedPathInfo($request);
              
              
              Severity: Minor
              Found in core/web/UrlManager.php - About 1 hr to fix

                Function appendConfig has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function appendConfig(&$config, ConfigDefinition $definition)
                    {
                        switch ($definition->getGroup()) {
                            case ConfigDefinition::GROUP_APPLICATIONS:
                                foreach ($definition->getConfig() as $k => $v) {
                Severity: Minor
                Found in core/Config.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function generateLabels has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function generateLabels($table)
                    {
                        $labels = [];
                        foreach ($table->columns as $column) {
                            if ($this->generateLabelsFromComments && !empty($column->comment)) {
                Severity: Minor
                Found in core/console/commands/BaseCrudController.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language