Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Formatters/User.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method formattableColumns has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function formattableColumns($type = null)
    {
        $ret = [
            'lastname' => (object) [
                'name' => _i('Cognome'),
Severity: Minor
Found in code/app/Formatters/User.php - About 1 hr to fix

    Method columnsByFeatures has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function columnsByFeatures($ret)
    {
        $current_gas = currentAbsoluteGas();

        if ($current_gas->hasFeature('shipping_places')) {
    Severity: Minor
    Found in code/app/Formatters/User.php - About 1 hr to fix

      Method columnsByType has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function columnsByType($ret, $type)
    {
        if ($type == 'export' || $type == 'all') {
            $ret['last_login'] = (object) [
                'name' => _i('Ultimo Accesso'),
      Severity: Minor
      Found in code/app/Formatters/User.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                            return $obj->birthday;
        Severity: Major
        Found in code/app/Formatters/User.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $ret;
          Severity: Major
          Found in code/app/Formatters/User.php - About 30 mins to fix

            Function columnsByFeatures has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function columnsByFeatures($ret)
    {
        $current_gas = currentAbsoluteGas();

        if ($current_gas->hasFeature('shipping_places')) {
            Severity: Minor
            Found in code/app/Formatters/User.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status