Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Helpers/Formatters.php

Summary

Maintainability
C
1 day
Test Coverage

Function output_csv has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

function output_csv($filename, $head, $contents, $format_callback, $out_file = null)
{
    $callback = function() use ($head, $contents, $format_callback, $out_file) {
        $csv_separator = currentAbsoluteGas()->getConfig('csv_separator');
Severity: Minor
Found in code/app/Helpers/Formatters.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method output_csv has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function output_csv($filename, $head, $contents, $format_callback, $out_file = null)
{
    $callback = function() use ($head, $contents, $format_callback, $out_file) {
        $csv_separator = currentAbsoluteGas()->getConfig('csv_separator');
Severity: Minor
Found in code/app/Helpers/Formatters.php - About 1 hr to fix

    Method iban_split has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function iban_split($iban, $field)
{
    switch($field) {
        case 'country':
            $start = 0;
    Severity: Minor
    Found in code/app/Helpers/Formatters.php - About 1 hr to fix

      Function iban_split has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function iban_split($iban, $field)
{
    switch($field) {
        case 'country':
            $start = 0;
      Severity: Minor
      Found in code/app/Helpers/Formatters.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method output_csv has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function output_csv($filename, $head, $contents, $format_callback, $out_file = null)
      Severity: Minor
      Found in code/app/Helpers/Formatters.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status