Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Helpers/Permissions.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method allPermissions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function allPermissions()
{
    $ret = [
        'App\Gas' => [
            'gas.access' => _i('Accesso consentito anche in manutenzione'),
Severity: Minor
Found in code/app/Helpers/Permissions.php - About 1 hr to fix

    Function roleByFunction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function roleByFunction($identifier)
{
    $gas = currentAbsoluteGas();
    $role_id = $gas->roles[$identifier] ?? null;
    $ret = App\Role::find($role_id);
    Severity: Minor
    Found in code/app/Helpers/Permissions.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method roleByFunction has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function roleByFunction($identifier)
{
    $gas = currentAbsoluteGas();
    $role_id = $gas->roles[$identifier] ?? null;
    $ret = App\Role::find($role_id);
    Severity: Minor
    Found in code/app/Helpers/Permissions.php - About 1 hr to fix

      Function rolesByClass has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function rolesByClass($asked_class)
{
    $roles = [];
    $all_permissions = allPermissions();
    $rules = $all_permissions[$asked_class] ?? [];
      Severity: Minor
      Found in code/app/Helpers/Permissions.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function someoneCan has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function someoneCan($permission, $subject = null)
{
    $basic_roles = App\Role::havingAction($permission);

    foreach($basic_roles as $br) {
      Severity: Minor
      Found in code/app/Helpers/Permissions.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status