Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Http/Controllers/ImportController.php

Summary

Maintainability
C
1 day
Test Coverage

Function readGdxpFile has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private function readGdxpFile($path, $execute, $supplier_replace)
    {
        $working_dir = sys_get_temp_dir();

        $data = [];
Severity: Minor
Found in code/app/Http/Controllers/ImportController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function postGdxp has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function postGdxp(Request $request)
    {
        // try {
            $archivepath = '';
            $working_dir = sys_get_temp_dir();
Severity: Minor
Found in code/app/Http/Controllers/ImportController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readGdxpFile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function readGdxpFile($path, $execute, $supplier_replace)
    {
        $working_dir = sys_get_temp_dir();

        $data = [];
Severity: Minor
Found in code/app/Http/Controllers/ImportController.php - About 1 hr to fix

    Method postCsv has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function postCsv(Request $request)
    {
        $type = $request->input('type');
        $step = $request->input('step', 'guess');
    Severity: Minor
    Found in code/app/Http/Controllers/ImportController.php - About 1 hr to fix

      Method postGdxp has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function postGdxp(Request $request)
    {
        // try {
            $archivepath = '';
            $working_dir = sys_get_temp_dir();
      Severity: Minor
      Found in code/app/Http/Controllers/ImportController.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return $this->errorResponse($e->getMessage());
        Severity: Major
        Found in code/app/Http/Controllers/ImportController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this->errorResponse(_i('Comando %s/%s non valido', [$type, $step]));
          Severity: Major
          Found in code/app/Http/Controllers/ImportController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return view($importer->finalTemplate(), $parameters);
            Severity: Major
            Found in code/app/Http/Controllers/ImportController.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status