Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Http/Controllers/StatisticsController.php

Summary

Maintainability
C
1 day
Test Coverage

Function getSupplier has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private function getSupplier($start, $end, $type, $target, $supplier)
    {
        $data = [];
        $categories = [];
Severity: Minor
Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getSummary has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getSummary($start, $end, $type, $target)
    {
        if ($type == 'all') {
            $data = $this->basicSummaryForAll($start, $end, $target);
        }
Severity: Minor
Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

    Method getSupplier has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getSupplier($start, $end, $type, $target, $supplier)
    {
        $data = [];
        $categories = [];
    Severity: Minor
    Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

      Function getSummary has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getSummary($start, $end, $type, $target)
    {
        if ($type == 'all') {
            $data = $this->basicSummaryForAll($start, $end, $target);
        }
      Severity: Minor
      Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function show(Request $request, $id)
    {
        $start = decodeDate($request->input('startdate'));
        $end = decodeDate($request->input('enddate'));
        $target = fromInlineId($request->input('target'));
      Severity: Minor
      Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

        Method createBookingQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function createBookingQuery($query, $type, $start, $end, $target, $supplier)
        Severity: Minor
        Found in code/app/Http/Controllers/StatisticsController.php - About 45 mins to fix

          Method getSupplier has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function getSupplier($start, $end, $type, $target, $supplier)
          Severity: Minor
          Found in code/app/Http/Controllers/StatisticsController.php - About 35 mins to fix

            Function basicSummaryForAll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function basicSummaryForAll($start, $end, $target)
    {
        $data = [];
        $bookings = $this->createBookingQuery(Booking::query(), 'all', $start, $end, $target, null)->angryload()->get();
            Severity: Minor
            Found in code/app/Http/Controllers/StatisticsController.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status