Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Http/Controllers/UsersController.php

Summary

Maintainability
B
5 hrs
Test Coverage

UsersController has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class UsersController extends BackedController
{
    public function __construct(UsersService $service)
    {
        $this->commonInit([
Severity: Minor
Found in code/app/Http/Controllers/UsersController.php - About 2 hrs to fix

    File UsersController.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
    Severity: Minor
    Found in code/app/Http/Controllers/UsersController.php - About 2 hrs to fix

      Function testInternalFunctionsAccess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function testInternalFunctionsAccess($requester, $target, $type)
    {
        $admin_editable = $requester->can('users.admin', $target->gas);
        $access = ($admin_editable || $requester->id == $target->id || $target->parent_id == $requester->id);
      Severity: Minor
      Found in code/app/Http/Controllers/UsersController.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status