code/app/Importers/CSV/Deliveries.php
Function select has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring. Open
Open
public function select($request)
{
$user = Auth::user();
$service = app()->make('BookingsService');
$errors = [];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method select has 98 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function select($request)
{
$user = Auth::user();
$service = app()->make('BookingsService');
$errors = [];Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function run($request)
{
$user = Auth::user();
$service = app()->make('BookingsService');
Avoid deeply nested control flow statements. Open
Open
if (isset($datarow['variant_selection_' . $variant_id]) == false) {
$datarow['variant_selection_' . $variant_id] = [];
}Avoid deeply nested control flow statements. Open
Open
if (isset($datarow['variant_quantity_' . $product_id]) == false) {
$datarow['variant_quantity_' . $product_id] = [];
}