Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Importers/CSV/Movements.php

Summary

Maintainability
D
2 days
Test Coverage

Function select has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

    public function select($request)
    {
        list($reader, $columns) = $this->initRead($request);
        $target_separator = ',';
Severity: Minor
Found in code/app/Importers/CSV/Movements.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method select has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function select($request)
    {
        list($reader, $columns) = $this->initRead($request);
        $target_separator = ',';
Severity: Major
Found in code/app/Importers/CSV/Movements.php - About 3 hrs to fix

    Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run($request)
    {
        $imports = $request->input('import', []);
        $dates = $request->input('date', []);
        $senders = $request->input('sender_id', []);
    Severity: Minor
    Found in code/app/Importers/CSV/Movements.php - About 1 hr to fix

      Method fields has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function fields()
    {
        $ret = [
            'date' => (object) [
                'label' => _i('Data'),
      Severity: Minor
      Found in code/app/Importers/CSV/Movements.php - About 1 hr to fix

        Function assignPeers has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function assignPeers($m, $senders, $targets, $index)
    {
        $t = MovementType::find($m->type);

        foreach(['sender', 'target'] as $f) {
        Severity: Minor
        Found in code/app/Importers/CSV/Movements.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function run($request)
    {
        $imports = $request->input('import', []);
        $dates = $request->input('date', []);
        $senders = $request->input('sender_id', []);
        Severity: Minor
        Found in code/app/Importers/CSV/Movements.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status