Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Importers/CSV/Products.php

Summary

Maintainability
D
2 days
Test Coverage

Function select has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public function select($request)
    {
        list($reader, $columns) = $this->initRead($request);
        list($name_index, $supplier_code_index) = $this->getColumnsIndex($columns, ['name', 'supplier_code']);
        $s = $this->getSupplier($request);
Severity: Minor
Found in code/app/Importers/CSV/Products.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method select has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function select($request)
    {
        list($reader, $columns) = $this->initRead($request);
        list($name_index, $supplier_code_index) = $this->getColumnsIndex($columns, ['name', 'supplier_code']);
        $s = $this->getSupplier($request);
Severity: Major
Found in code/app/Importers/CSV/Products.php - About 3 hrs to fix

    Method run has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run($request)
    {
        DB::beginTransaction();

        $direct_fields = ['name', 'weight', 'description', 'price', 'supplier_code', 'package_size', 'min_quantity', 'multiple', 'portion_quantity'];
    Severity: Major
    Found in code/app/Importers/CSV/Products.php - About 2 hrs to fix

      Function run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run($request)
    {
        DB::beginTransaction();

        $direct_fields = ['name', 'weight', 'description', 'price', 'supplier_code', 'package_size', 'min_quantity', 'multiple', 'portion_quantity'];
      Severity: Minor
      Found in code/app/Importers/CSV/Products.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fields has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function fields()
    {
        return [
            'name' => (object) [
                'label' => _i('Nome'),
      Severity: Minor
      Found in code/app/Importers/CSV/Products.php - About 1 hr to fix

        Method mapSelection has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function mapSelection($objects, $param, $value, $field, &$product)
        Severity: Minor
        Found in code/app/Importers/CSV/Products.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status