Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Importers/GDXP/Suppliers.php

Summary

Maintainability
C
1 day
Test Coverage

Function importXML has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public static function importXML($xml, $replace)
    {
        if (is_null($replace)) {
            $supplier = new Supplier();
            $supplier->payment_method = '';
Severity: Minor
Found in code/app/Importers/GDXP/Suppliers.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method importXML has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function importXML($xml, $replace)
    {
        if (is_null($replace)) {
            $supplier = new Supplier();
            $supplier->payment_method = '';
Severity: Major
Found in code/app/Importers/GDXP/Suppliers.php - About 2 hrs to fix

    Method importJSON has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function importJSON($master, $json, $replace)
    {
        if (is_null($replace)) {
            $supplier = new Supplier();
            $supplier->payment_method = '';
    Severity: Minor
    Found in code/app/Importers/GDXP/Suppliers.php - About 1 hr to fix

      Function readXML has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function readXML($xml)
    {
        $supplier = new Supplier();
        $products = new Collection();
        $orders = new Collection();
      Severity: Minor
      Found in code/app/Importers/GDXP/Suppliers.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function importJSON has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function importJSON($master, $json, $replace)
    {
        if (is_null($replace)) {
            $supplier = new Supplier();
            $supplier->payment_method = '';
      Severity: Minor
      Found in code/app/Importers/GDXP/Suppliers.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status