Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Jobs/NotifyClosedOrder.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function handle has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function handle()
    {
        $printer = new OrderPrinter();
        $notifiable_users = [];
        $all_files = [];
Severity: Minor
Found in code/app/Jobs/NotifyClosedOrder.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $printer = new OrderPrinter();
        $notifiable_users = [];
        $all_files = [];
Severity: Minor
Found in code/app/Jobs/NotifyClosedOrder.php - About 1 hr to fix

    Function dispatchToSupplier has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private function dispatchToSupplier($order)
    {
        if ($order->isRunning() == false) {
            $supplier = $order->supplier;
    Severity: Minor
    Found in code/app/Jobs/NotifyClosedOrder.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function filesForSupplier has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function filesForSupplier($order)
    {
        $printer = new OrderPrinter();

        $type = $order->supplier->notify_on_close_enabled;
    Severity: Minor
    Found in code/app/Jobs/NotifyClosedOrder.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function dispatchToReferents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function dispatchToReferents($notifiable_users)
    {
        foreach($notifiable_users as $notifiable) {
            if ($notifiable->user->gas->auto_referent_order_summary) {
                try {
    Severity: Minor
    Found in code/app/Jobs/NotifyClosedOrder.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status