Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Models/Concerns/ReducibleTrait.php

Summary

Maintainability
C
1 day
Test Coverage

Function minimumRedux has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function minimumRedux($modifiers)
    {
        if ($modifiers->isEmpty()) {
            return [];
        }
Severity: Minor
Found in code/app/Models/Concerns/ReducibleTrait.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method minimumRedux has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function minimumRedux($modifiers)
    {
        if ($modifiers->isEmpty()) {
            return [];
        }
Severity: Major
Found in code/app/Models/Concerns/ReducibleTrait.php - About 2 hrs to fix

    Function descendReduction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function descendReduction($ret, $filters)
    {
        foreach ($this->describingAttributes() as $attr) {
            if (!isset($ret->$attr)) {
                $ret->$attr = 0;
    Severity: Minor
    Found in code/app/Models/Concerns/ReducibleTrait.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function describingAttributesMerge has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function describingAttributesMerge($first, $second)
    {
        if (is_null($first)) {
            return clone $second;
        }
    Severity: Minor
    Found in code/app/Models/Concerns/ReducibleTrait.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deepMergingAttributes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function deepMergingAttributes($child, $first, $second)
    {
        $ret = $this->describingAttributesMerge($first, $second);

        foreach ($this->subArrayMerge() as $subarray) {
    Severity: Minor
    Found in code/app/Models/Concerns/ReducibleTrait.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status