Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Observers/MovementObserver.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function saving has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function saving(Movement $movement)
    {
        if ($this->movements_hub->isSuspended()) {
            return true;
        }
Severity: Minor
Found in code/app/Observers/MovementObserver.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method saving has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function saving(Movement $movement)
    {
        if ($this->movements_hub->isSuspended()) {
            return true;
        }
Severity: Minor
Found in code/app/Observers/MovementObserver.php - About 1 hr to fix

    Function verifyConsistency has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function verifyConsistency($movement)
    {
        $metadata = $movement->type_metadata;

        if (is_null($metadata)) {
    Severity: Minor
    Found in code/app/Observers/MovementObserver.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in code/app/Observers/MovementObserver.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->verifyConsistency($movement);
      Severity: Major
      Found in code/app/Observers/MovementObserver.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in code/app/Observers/MovementObserver.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status