Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Printers/Aggregate.php

Summary

Maintainability
D
1 day
Test Coverage

Function handleShipping has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handleShipping($obj, $request)
    {
        $subtype = $request['format'] ?? 'pdf';
        $required_fields = $request['fields'] ?? [];
Severity: Minor
Found in code/app/Printers/Aggregate.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handleShipping has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function handleShipping($obj, $request)
    {
        $subtype = $request['format'] ?? 'pdf';
        $required_fields = $request['fields'] ?? [];
Severity: Major
Found in code/app/Printers/Aggregate.php - About 2 hrs to fix

    Function handleSummary has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function handleSummary($obj, $request)
    {
        $subtype = $request['format'] ?? 'pdf';

        if ($subtype == 'gdxp') {
    Severity: Minor
    Found in code/app/Printers/Aggregate.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleSummary has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleSummary($obj, $request)
    {
        $subtype = $request['format'] ?? 'pdf';

        if ($subtype == 'gdxp') {
    Severity: Minor
    Found in code/app/Printers/Aggregate.php - About 1 hr to fix

      Method formatTableRows has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function formatTableRows($aggregate, $shipping_place, $status, $fields, &$all_products)
      Severity: Minor
      Found in code/app/Printers/Aggregate.php - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

                    return output_csv($filename, $data->headers, $flat_contents, function($row) {
                return $row;
            });
        Severity: Major
        Found in code/app/Printers/Aggregate.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status