Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Printers/Concerns/Summary.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method formatSummaryShipping has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function formatSummaryShipping($order, $fields, $status, $shipping_place, $extra_modifiers)
    {
        $rows = [];
        $total = 0;
        $formattable = OrderFormatter::formattableColumns('summary');
Severity: Minor
Found in code/app/Printers/Concerns/Summary.php - About 1 hr to fix

    Function formatSummaryShipping has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function formatSummaryShipping($order, $fields, $status, $shipping_place, $extra_modifiers)
    {
        $rows = [];
        $total = 0;
        $formattable = OrderFormatter::formattableColumns('summary');
    Severity: Minor
    Found in code/app/Printers/Concerns/Summary.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function formatSummary has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function formatSummary($order, $document, $fields, $status, $shipping_place, $extra_modifiers)
    {
        if ($shipping_place && $shipping_place == 'all_by_place') {
            $places = Delivery::orderBy('name', 'asc')->get();
            foreach($places as $place) {
    Severity: Minor
    Found in code/app/Printers/Concerns/Summary.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method formatSummary has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function formatSummary($order, $document, $fields, $status, $shipping_place, $extra_modifiers)
    Severity: Minor
    Found in code/app/Printers/Concerns/Summary.php - About 45 mins to fix

      Method addModifiers has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function addModifiers($order, $summary, $status, $total, $fields, $extra_modifiers)
      Severity: Minor
      Found in code/app/Printers/Concerns/Summary.php - About 45 mins to fix

        Method formatSummaryShipping has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function formatSummaryShipping($order, $fields, $status, $shipping_place, $extra_modifiers)
        Severity: Minor
        Found in code/app/Printers/Concerns/Summary.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status