Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Printers/Order.php

Summary

Maintainability
D
2 days
Test Coverage

Function handleSummary has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handleSummary($obj, $request)
    {
        $action = $request['action'] ?? 'download';
        $subtype = $request['format'] ?? 'pdf';
        $extra_modifiers = $request['extra_modifiers'] ?? 0;
Severity: Minor
Found in code/app/Printers/Order.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleShipping has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handleShipping($obj, $request)
    {
        $action = $request['action'] ?? 'download';
        $subtype = $request['format'] ?? 'pdf';
        $status = $request['status'] ?? 'pending';
Severity: Minor
Found in code/app/Printers/Order.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handleShipping has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function handleShipping($obj, $request)
    {
        $action = $request['action'] ?? 'download';
        $subtype = $request['format'] ?? 'pdf';
        $status = $request['status'] ?? 'pending';
Severity: Major
Found in code/app/Printers/Order.php - About 2 hrs to fix

    Method handleSummary has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleSummary($obj, $request)
    {
        $action = $request['action'] ?? 'download';
        $subtype = $request['format'] ?? 'pdf';
        $extra_modifiers = $request['extra_modifiers'] ?? 0;
    Severity: Major
    Found in code/app/Printers/Order.php - About 2 hrs to fix

      Method handleTable has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function handleTable($obj, $request)
    {
        $action = $request['action'] ?? 'download';
        $status = $request['status'] ?? 'pending';
        $include_missing = $request['include_missing'] ?? 'no';
      Severity: Minor
      Found in code/app/Printers/Order.php - About 1 hr to fix

        Function handleTable has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function handleTable($obj, $request)
    {
        $action = $request['action'] ?? 'download';
        $status = $request['status'] ?? 'pending';
        $include_missing = $request['include_missing'] ?? 'no';
        Severity: Minor
        Found in code/app/Printers/Order.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method formatTableRows has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function formatTableRows($order, $shipping_place, $status, $fields, &$all_products)
        Severity: Minor
        Found in code/app/Printers/Order.php - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $document->download($filename);
          Severity: Major
          Found in code/app/Printers/Order.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $temp_file_path;
            Severity: Major
            Found in code/app/Printers/Order.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status