Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Printers/Order.php

Summary

Maintainability
C
1 day
Test Coverage

Function handleShipping has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handleShipping($obj, $request)
    {
        $send_mail = isset($request['send_mail']);
        $subtype = $request['format'] ?? 'pdf';
        $status = $request['status'] ?? 'pending';
Severity: Minor
Found in code/app/Printers/Order.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handleShipping has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function handleShipping($obj, $request)
    {
        $send_mail = isset($request['send_mail']);
        $subtype = $request['format'] ?? 'pdf';
        $status = $request['status'] ?? 'pending';
Severity: Major
Found in code/app/Printers/Order.php - About 2 hrs to fix

    Method handleSummary has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleSummary($obj, $request)
    {
        $send_mail = isset($request['send_mail']);
        $subtype = $request['format'] ?? 'pdf';
        $extra_modifiers = $request['extra_modifiers'] ?? 0;
    Severity: Minor
    Found in code/app/Printers/Order.php - About 1 hr to fix

      Function handleSummary has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function handleSummary($obj, $request)
    {
        $send_mail = isset($request['send_mail']);
        $subtype = $request['format'] ?? 'pdf';
        $extra_modifiers = $request['extra_modifiers'] ?? 0;
      Severity: Minor
      Found in code/app/Printers/Order.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleTable has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function handleTable($obj, $request)
    {
        $send_mail = isset($request['send_mail']);
        $status = $request['status'] ?? 'pending';
        $include_missing = $request['include_missing'] ?? 'no';
      Severity: Minor
      Found in code/app/Printers/Order.php - About 1 hr to fix

        Function autoGuessFields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function autoGuessFields($order)
    {
        $guessed_fields = [];

        foreach($order->products as $product) {
        Severity: Minor
        Found in code/app/Printers/Order.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method formatTableRows has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function formatTableRows($order, $shipping_place, $status, $fields, &$all_products)
        Severity: Minor
        Found in code/app/Printers/Order.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status