Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Product.php

Summary

Maintainability
C
1 day
Test Coverage

File Product.php has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
Severity: Minor
Found in code/app/Product.php - About 3 hrs to fix

    Product has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Product extends Model
{
    use HasFactory, SoftDeletes, ProductConcept, TracksUpdater, Priceable, ModifiableTrait, GASModel, SluggableID, Cachable;

    public $incrementing = false;
    Severity: Minor
    Found in code/app/Product.php - About 2 hrs to fix

      Method displayColumns has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function displayColumns()
    {
        $ret = [];

        $gas = currentAbsoluteGas();
      Severity: Minor
      Found in code/app/Product.php - About 1 hr to fix

        Function comparePrices has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function comparePrices($other)
    {
        if ($this->getPrice(false) != $other->getPrice(false)) {
            return false;
        }
        Severity: Minor
        Found in code/app/Product.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function hasWarningWithinOrder has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function hasWarningWithinOrder($summary)
    {
        if (isset($summary->products[$this->id])) {
            $quantity = $summary->products[$this->id]->quantity;
        Severity: Minor
        Found in code/app/Product.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status