Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Services/FastBookingsService.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function sumUpProducts has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    private function sumUpProducts($booking, &$datarow)
    {
        /*
            TODO: Nel caso di prenotazioni salvate sarebbe molto più efficiente
            cambiare semplicemente lo stato della prenotazione stessa, giacché
Severity: Minor
Found in code/app/Services/FastBookingsService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fastShipping has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fastShipping($deliverer, $aggregate, $users = null)
    {
        DB::beginTransaction();

        $service = app()->make('BookingsService');
Severity: Minor
Found in code/app/Services/FastBookingsService.php - About 1 hr to fix

    Method sumUpProducts has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function sumUpProducts($booking, &$datarow)
    {
        /*
            TODO: Nel caso di prenotazioni salvate sarebbe molto più efficiente
            cambiare semplicemente lo stato della prenotazione stessa, giacché
    Severity: Minor
    Found in code/app/Services/FastBookingsService.php - About 1 hr to fix

      Function fastShipping has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fastShipping($deliverer, $aggregate, $users = null)
    {
        DB::beginTransaction();

        $service = app()->make('BookingsService');
      Severity: Minor
      Found in code/app/Services/FastBookingsService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status