Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Services/ModifiersService.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function update has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function update($id, array $request)
    {
        $modifier = $this->show($id);
        $this->testAccess($modifier);
Severity: Minor
Found in code/app/Services/ModifiersService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update($id, array $request)
    {
        $modifier = $this->show($id);
        $this->testAccess($modifier);
Severity: Minor
Found in code/app/Services/ModifiersService.php - About 1 hr to fix

    Function testAccess has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function testAccess($modifier)
    {
        switch($modifier->target_type) {
            case 'App\Supplier':
                $this->ensureAuth(['supplier.modify' => $modifier->target]);
    Severity: Minor
    Found in code/app/Services/ModifiersService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method testAccess has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function testAccess($modifier)
    {
        switch($modifier->target_type) {
            case 'App\Supplier':
                $this->ensureAuth(['supplier.modify' => $modifier->target]);
    Severity: Minor
    Found in code/app/Services/ModifiersService.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status