Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Services/MovementsService.php

Summary

Maintainability
D
1 day
Test Coverage

Function list has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function list($request)
    {
        /*
            TODO sarebbe assai più efficiente usare with('sender') e
            with('target'), ma poi la relazione in Movement si spacca (cambiando
Severity: Minor
Found in code/app/Services/MovementsService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MovementsService.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Services;

use App\Exceptions\IllegalArgumentException;
Severity: Minor
Found in code/app/Services/MovementsService.php - About 3 hrs to fix

    Method list has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function list($request)
    {
        /*
            TODO sarebbe assai più efficiente usare with('sender') e
            with('target'), ma poi la relazione in Movement si spacca (cambiando
    Severity: Major
    Found in code/app/Services/MovementsService.php - About 2 hrs to fix

      Method closeBalance has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function closeBalance($request)
    {
        $this->ensureAuth(['movements.admin' => 'gas']);
        $hub = App::make('MovementsHub');
      Severity: Minor
      Found in code/app/Services/MovementsService.php - About 1 hr to fix

        Function filterBySupplier has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function filterBySupplier($supplier, $user, $query, $own)
    {
        $type = 'all';

        if ($supplier) {
        Severity: Minor
        Found in code/app/Services/MovementsService.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method filterBySupplier has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function filterBySupplier($supplier, $user, $query, $own)
    {
        $type = 'all';

        if ($supplier) {
        Severity: Minor
        Found in code/app/Services/MovementsService.php - About 1 hr to fix

          Function creditHistory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function creditHistory($class, $date)
    {
        $currencies = Currency::enabled();
        $balances = Balance::whereDate('date', $date)->where('target_type', $class)->get();
        $ret = [];
          Severity: Minor
          Found in code/app/Services/MovementsService.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status