Sign upLogin

madbob/GASdottoNG

View on GitHub
Star
code/app/Services/UsersService.php

Summary

Maintainability
C
1 day
Test Coverage

Function updateAccessType has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private function updateAccessType($id, $request)
    {
        $user = Auth::user();
        if (is_null($user)) {
            throw new AuthException(401);
Severity: Minor
Found in code/app/Services/UsersService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File UsersService.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Services;

use App\Exceptions\AuthException;
Severity: Minor
Found in code/app/Services/UsersService.php - About 2 hrs to fix

    Method updateAccessType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function updateAccessType($id, $request)
    {
        $user = Auth::user();
        if (is_null($user)) {
            throw new AuthException(401);
    Severity: Minor
    Found in code/app/Services/UsersService.php - About 1 hr to fix

      Method update has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function update($id, array $request)
    {
        $type = $this->updateAccessType($id, $request);
        if (is_object($type)) {
            return $type;
      Severity: Minor
      Found in code/app/Services/UsersService.php - About 1 hr to fix

        Function readRID has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function readRID($user, $request)
    {
        if ($user->gas->hasFeature('rid')) {
            $rid = $user->rid;
            $changed = false;
        Severity: Minor
        Found in code/app/Services/UsersService.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function update($id, array $request)
    {
        $type = $this->updateAccessType($id, $request);
        if (is_object($type)) {
            return $type;
        Severity: Minor
        Found in code/app/Services/UsersService.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function revisioned has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function revisioned($id, $approved)
    {
        DB::beginTransaction();

        $user = $this->show($id);
        Severity: Minor
        Found in code/app/Services/UsersService.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status