Sign upLogin

madetech/market_town

View on GitHub
Star
checkout/lib/market_town/checkout/integrations/spree/fulfilments.rb

Summary

Maintainability
A
0 mins
Test Coverage

Put empty method definitions on a single line.
Open

        def apply_shipment_costs(state)
        end
Severity: Minor
Found in checkout/lib/market_town/checkout/integrations/spree/fulfilments.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Put empty method definitions on a single line.
Open

        def fulfil(state)
        end
Severity: Minor
Found in checkout/lib/market_town/checkout/integrations/spree/fulfilments.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

This conditional expression can just be replaced by !(state[:order].send(:ensure_available_shipping_rates) == false).
Open

          if state[:order].send(:ensure_available_shipping_rates) == false
            false
          else
            true
          end
Severity: Minor
Found in checkout/lib/market_town/checkout/integrations/spree/fulfilments.rb by rubocop

This cop checks for redundant returning of true/false in conditionals.

Example:

# bad
x == y ? true : false

# bad
if x == y
  true
else
  false
end

# good
x == y

# bad
x == y ? false : true

# good
x != y

There are no issues that match your filters.

Category
Status