Sign upLogin

madhav-datt/kgp-hms

View on GitHub
Star
src/ui/HMC_GUI.py

Summary

Maintainability
C
1 day
Test Coverage

Cyclomatic complexity is too high in method add_hall. (17)
Open

    def add_hall(self):
        """
        Add ui elements for add hall tab
        Create new hall
        Assign warden, mess manager and hall office clerk
Severity: Minor
Found in src/ui/HMC_GUI.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

File HMC_GUI.py has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# IIT Kharagpur - Hall Management System
# System to manage Halls of residences, Warden grant requests, student complaints
# hall worker attendances and salary payments
#
Severity: Minor
Found in src/ui/HMC_GUI.py - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if name == "" or amenities_charge == 0. or single_room_count == 0 or single_room_rent == 0 \
                or double_room_count == 0 or double_room_rent == 0 or warden_name == "" or warden_pw == "" or \
                manager_name == "" or manager_pw == "" or manager_salary == 0. or clerk_name == "" or clerk_pw == "" \
                or clerk_salary == 0.:
            choice = QtGui.QMessageBox.question(self, 'Error', "No Field can be left blank")
    Severity: Critical
    Found in src/ui/HMC_GUI.py - About 3 hrs to fix

      Cyclomatic complexity is too high in method issue_admission_letter. (8)
      Open

          def issue_admission_letter(self):
        """
        Add new student, allot hall
        Print admission letter in PDF
        """
      Severity: Minor
      Found in src/ui/HMC_GUI.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function password_validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def password_validate(self):
        """
        Validate password and login
        """
      Severity: Minor
      Found in src/ui/HMC_GUI.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_warden_req has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_warden_req(self):
        """
        Invoked upon pushing "View Request" button
        Display selected grant request
        """
      Severity: Minor
      Found in src/ui/HMC_GUI.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function issue_admission_letter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def issue_admission_letter(self):
        """
        Add new student, allot hall
        Print admission letter in PDF
        """
      Severity: Minor
      Found in src/ui/HMC_GUI.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status