mambax7/extcal

View on GitHub

Showing 1,163 of 1,163 total issues

Function createOverlay has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        createOverlay: function (o) {
            var el = o.overlayId,
                relToVP = (o.relativeTo == 'viewport' && !/panel$/.test(o.position));
            if (typeof el == 'string') el = hs.getNode(el);
            if (o.html) el = hs.createElement('div', {innerHTML: o.html});
Severity: Minor
Found in assets/js/highslide-full.js - About 1 hr to fix

    Function correctRatio has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            correctRatio: function (ratio) {
                var x = this.x,
                    y = this.y,
                    changed = false,
                    xSize = Math.min(x.full, x.size),
    Severity: Minor
    Found in assets/js/highslide-full.js - About 1 hr to fix

      Function correctRatio has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              correctRatio: function (ratio) {
                  var x = this.x,
                      y = this.y,
                      changed = false,
                      xSize = Math.min(x.full, x.size),
      Severity: Minor
      Found in assets/js/highslide-with-gallery.js - About 1 hr to fix

        Method bExtcalUpcomingShow has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function bExtcalUpcomingShow($options)
        {
            /** @var Helper $helper */
            if (!class_exists(Helper::class)) {
                return false;
        Severity: Minor
        Found in blocks/upcoming.php - About 1 hr to fix

          Function correctRatio has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  correctRatio: function (ratio) {
                      var x = this.x,
                          y = this.y,
                          changed = false,
                          xSize = Math.min(x.full, x.size),
          Severity: Minor
          Found in assets/js/highslide.js - About 1 hr to fix

            Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $caption,
                    $name,
                    $value = 0,
                    $min = 0,
                    $max = 100,
            Severity: Major
            Found in class/Form/Spin/FormSpin.php - About 1 hr to fix

              Function showHideElements has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      showHideElements: function (tagName, visibility) {
                          var els = document.getElementsByTagName(tagName);
                          var prop = tagName == '*' ? 'overflow' : 'visibility';
                          for (var i = 0; i < els.length; i++) {
                              if (prop == 'visibility' || (document.defaultView.getComputedStyle(
              Severity: Minor
              Found in assets/js/highslide-full.js - About 1 hr to fix

                Function showHideElements has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        showHideElements: function (tagName, visibility) {
                            var els = document.getElementsByTagName(tagName);
                            var prop = tagName == '*' ? 'overflow' : 'visibility';
                            for (var i = 0; i < els.length; i++) {
                                if (prop == 'visibility' || (document.defaultView.getComputedStyle(
                Severity: Minor
                Found in assets/js/highslide-with-gallery.js - About 1 hr to fix

                  Function createOverlay has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          createOverlay: function (o) {
                              var el = o.overlayId,
                                  relToVP = (o.relativeTo == 'viewport' && !/panel$/.test(o.position));
                              if (typeof el == 'string') el = hs.getNode(el);
                              if (o.html) el = hs.createElement('div', {innerHTML: o.html});
                  Severity: Minor
                  Found in assets/js/highslide-with-gallery.js - About 1 hr to fix

                    Function keyHandler has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            keyHandler: function (e) {
                                if (!e) e = window.event;
                                if (!e.target) e.target = e.srcElement; // ie
                                if (typeof e.target.form != 'undefined') return true; // form element has focus
                                var exp = hs.getExpander();
                    Severity: Minor
                    Found in assets/js/highslide.js - About 1 hr to fix

                      Function ControlVersion has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function ControlVersion() {
                          var version;
                          var axo;
                          var e;
                      
                      
                      Severity: Minor
                      Found in assets/js/AC_RunActiveContent.js - About 1 hr to fix

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if (this.gotOverlays) {
                                        this.positionOverlay(overlay);
                                        if (!overlay.hideOnMouseOut || this.mouseIsOver)
                                            hs.animate(overlay, {opacity: overlay.opacity}, overlay.dur);
                                    }
                        Severity: Major
                        Found in assets/js/highslide.js and 2 other locations - About 1 hr to fix
                        assets/js/highslide-full.js on lines 2731..2735
                        assets/js/highslide-with-gallery.js on lines 2149..2153

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if (this.gotOverlays) {
                                        this.positionOverlay(overlay);
                                        if (!overlay.hideOnMouseOut || this.mouseIsOver)
                                            hs.animate(overlay, {opacity: overlay.opacity}, overlay.dur);
                                    }
                        Severity: Major
                        Found in assets/js/highslide-full.js and 2 other locations - About 1 hr to fix
                        assets/js/highslide-with-gallery.js on lines 2149..2153
                        assets/js/highslide.js on lines 1643..1647

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if (this.gotOverlays) {
                                        this.positionOverlay(overlay);
                                        if (!overlay.hideOnMouseOut || this.mouseIsOver)
                                            hs.animate(overlay, {opacity: overlay.opacity}, overlay.dur);
                                    }
                        Severity: Major
                        Found in assets/js/highslide-with-gallery.js and 2 other locations - About 1 hr to fix
                        assets/js/highslide-full.js on lines 2731..2735
                        assets/js/highslide.js on lines 1643..1647

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function css has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                css: function (el, prop) {
                                    if (el.style[prop]) {
                                        return el.style[prop];
                                    } else if (document.defaultView) {
                                        return document.defaultView.getComputedStyle(el, null).getPropertyValue(prop);
                        Severity: Minor
                        Found in assets/js/highslide-full.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function getImageMapAreaCorrection has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                getImageMapAreaCorrection: function (area) {
                                    var c = area.coords.split(',');
                                    for (var i = 0; i < c.length; i++) c[i] = parseInt(c[i]);
                        
                                    if (area.shape.toLowerCase() == 'circle') {
                        Severity: Minor
                        Found in assets/js/highslide-full.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function css has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                css: function (el, prop) {
                                    if (el.style[prop]) {
                                        return el.style[prop];
                                    } else if (document.defaultView) {
                                        return document.defaultView.getComputedStyle(el, null).getPropertyValue(prop);
                        Severity: Minor
                        Found in assets/js/highslide-with-gallery.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function Outline has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            hs.Outline = function (outlineType, onLoad) {
                                this.onLoad = onLoad;
                                this.outlineType = outlineType;
                                var v = hs.uaVersion, tr;
                        
                        
                        Severity: Minor
                        Found in assets/js/highslide-full.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function get has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                get: function (key) {
                                    switch (key) {
                                        case 'loadingPos':
                                            return this.tpos + this.tb + (this.t - hs.loading['offset' + this.ucwh]) / 2;
                                        case 'loadingPosXfade':
                        Severity: Minor
                        Found in assets/js/highslide-full.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function destroyOverlays has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                destroyOverlays: function () {
                                    if (!this.overlays.length) return;
                                    if (this.slideshow) {
                                        var c = this.slideshow.controls;
                                        if (c && hs.getExpander(c) == this) c.parentNode.removeChild(c);
                        Severity: Minor
                        Found in assets/js/highslide-with-gallery.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language