Sign upLogin

mambax7/gwiki

View on GitHub
Star

Showing 181 of 181 total issues

Method renderRef has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function renderRef($matches)
    {
        $refinfo      = $matches[1];
        $source       = $matches[2];
        $first_ref    = false;
Severity: Minor
Found in class/GwikiPage.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        while (false !== ($row = $xoopsDB->fetchArray($result))) {
        $row['pageurl']  = sprintf($wikiPage->getWikiLinkURL(), $row['keyword']);
        $row['pagelink'] = sprintf('<a href="%s" title="%s">%s</a>', $row['pageurl'], htmlspecialchars($row['title'], ENT_COMPAT), $row['title']);
        $related[]       = $row;
    }
    Severity: Major
    Found in blocks/blocks.php and 1 other location - About 1 hr to fix
    blocks/blocks.php on lines 624..628

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        while (false !== ($row = $xoopsDB->fetchArray($result))) {
        $row['pageurl']  = sprintf($wikiPage->getWikiLinkURL(), $row['keyword']);
        $row['pagelink'] = sprintf('<a href="%s" title="%s">%s</a>', $row['pageurl'], htmlspecialchars($row['title'], ENT_COMPAT), $row['title']);
        $linkshere[]     = $row;
    }
    Severity: Major
    Found in blocks/blocks.php and 1 other location - About 1 hr to fix
    blocks/blocks.php on lines 523..527

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method updateFile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function updateFile($newfile, &$input)
{
    global $uploadpath, $xoopsDB;
    // For now, images are stored in individual directories for each page.
    // We can change the directory distribution later, as the entire path
    Severity: Minor
    Found in ajaxfileedit.php - About 1 hr to fix

      Function getPrefix has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPrefix($keyword)
    {
        /*
         gwiki_prefix columns
          prefix_id
      Severity: Minor
      Found in class/GwikiPage.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function installTemplate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function installTemplate($pid, $delete = false)
{
    global $xoopsModule;

    $template = getPrefix($pid);
      Severity: Minor
      Found in admin/prefixes.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function doImportHTML has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function doImportHTML($page, $import_html, $dir)
{
    $import   = '';
    $pathname = XOOPS_ROOT_PATH . '/uploads/' . $dir . '/';
    if (isset($_POST['xoops_upload_file'][0])) {
      Severity: Minor
      Found in wizard.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function showPrefixes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function showPrefixes()
{
    global $xoopsDB;
    /*
    gwiki_prefix
      Severity: Minor
      Found in admin/prefixes.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method doImportHTML has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function doImportHTML($page, $import_html, $dir)
{
    $import   = '';
    $pathname = XOOPS_ROOT_PATH . '/uploads/' . $dir . '/';
    if (isset($_POST['xoops_upload_file'][0])) {
      Severity: Minor
      Found in wizard.php - About 1 hr to fix

        Method showPageTool has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function showPageTool($page, $id)
{
    global $xoopsDB, $wikiPage, $xoTheme;
    $helper = Helper::getInstance();
        Severity: Minor
        Found in admin/pages.php - About 1 hr to fix

          Method recentIndex has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function recentIndex($prefix = null)
    {
        global $xoopsDB;

        // only show active pages
          Severity: Minor
          Found in class/GwikiPage.php - About 1 hr to fix

            Method fetchPageSetToc has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function fetchPageSetToc(&$page)
    {
        global $xoopsDB;
        $toc = false;
            Severity: Minor
            Found in class/GwikiPage.php - About 1 hr to fix

              Method b_gwiki_wikiblock_show has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function b_gwiki_wikiblock_show($options)
{
    global $xoopsConfig, $xoTheme;

    $block = false;
              Severity: Minor
              Found in blocks/blocks.php - About 1 hr to fix

                Method do_clean has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function do_clean()
{
    global $xoopsDB;

    global $keywordpattern, $retainhours, $dir;
                Severity: Minor
                Found in extras/cleanlitterbox.php - About 1 hr to fix

                  Method updateImage has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function updateImage($newimage, &$input)
{
    global $uploadpath, $xoopsDB;
    // For now, images are stored in individual directories for each page.
    // We can change the directory distribution later, as the entire path
                  Severity: Minor
                  Found in ajaximgedit.php - About 1 hr to fix

                    Method fetchPageSet has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function fetchPageSet($page)
{
    global $xoopsDB, $wikiPage, $page_set_home, $display_keyword;

    $q_page = $wikiPage->escapeForDB($page);
                    Severity: Minor
                    Found in sortpageset.php - About 1 hr to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if ($linkshere) {
        $block['linkshere'] = $linkshere;

        $xoTheme->addStylesheet(XOOPS_URL . '/modules/' . $dir . '/assets/css/module.css');
                      Severity: Major
                      Found in blocks/blocks.php and 2 other locations - About 1 hr to fix
                      blocks/blocks.php on lines 418..427
                      blocks/blocks.php on lines 530..539

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 106.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if ($related) {
        $block['related'] = $related;

        $xoTheme->addStylesheet(XOOPS_URL . '/modules/' . $dir . '/assets/css/module.css');
                      Severity: Major
                      Found in blocks/blocks.php and 2 other locations - About 1 hr to fix
                      blocks/blocks.php on lines 418..427
                      blocks/blocks.php on lines 631..640

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 106.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if ($toc) {
        $block['toc'] = $toc;

        $xoTheme->addStylesheet(XOOPS_URL . '/modules/' . $dir . '/assets/css/module.css');
                      Severity: Major
                      Found in blocks/blocks.php and 2 other locations - About 1 hr to fix
                      blocks/blocks.php on lines 530..539
                      blocks/blocks.php on lines 631..640

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 106.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function getPlain has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function getPlain($count, $loremipsum, $returnStr = true)
    {
        $words = [];
        $this->getWords($words, $count, $loremipsum);
        //print_r($words);
                      Severity: Minor
                      Found in testing/LoremIpsumGenerator.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language