Sign upLogin

mambax7/mymenus

View on GitHub
Star
class/LinksUtility.php

Summary

Maintainability
C
1 day
Test Coverage

Method editLink has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function editLink($id = null, $pid = null, $mid = null)
    {
        $helper = Helper::getInstance();
        //
        // Disable xoops debugger in dialog window
Severity: Major
Found in class/LinksUtility.php - About 3 hrs to fix

    Function editLink has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function editLink($id = null, $pid = null, $mid = null)
    {
        $helper = Helper::getInstance();
        //
        // Disable xoops debugger in dialog window
    Severity: Minor
    Found in class/LinksUtility.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addLink has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function addLink($mid): void
    {
        $helper = Helper::getInstance();

        if (!$GLOBALS['xoopsSecurity']->check()) {
    Severity: Minor
    Found in class/LinksUtility.php - About 1 hr to fix

      Method saveLink has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function saveLink($id, $mid): void
    {
        $helper       = Helper::getInstance();
        $linksHandler = $helper->getHandler('Links');
      Severity: Minor
      Found in class/LinksUtility.php - About 1 hr to fix

        Function saveLink has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function saveLink($id, $mid): void
    {
        $helper       = Helper::getInstance();
        $linksHandler = $helper->getHandler('Links');
        Severity: Minor
        Found in class/LinksUtility.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addLink has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function addLink($mid): void
    {
        $helper = Helper::getInstance();

        if (!$GLOBALS['xoopsSecurity']->check()) {
        Severity: Minor
        Found in class/LinksUtility.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status