Sign upLogin

mambax7/xoopsheadline

View on GitHub
Star
class/HeadlineRenderer.php

Summary

Maintainability
D
1 day
Test Coverage

Function renderFeed has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public function renderFeed(bool $force_update = false): bool
    {
        $retval = false;
        if ($force_update || $this->headline->cacheExpired()) {
            if (!$this->updateCache()) {
Severity: Minor
Found in class/HeadlineRenderer.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renderFeed has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function renderFeed(bool $force_update = false): bool
    {
        $retval = false;
        if ($force_update || $this->headline->cacheExpired()) {
            if (!$this->updateCache()) {
Severity: Major
Found in class/HeadlineRenderer.php - About 2 hrs to fix

    Function updateCache has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateCache()
    {
        $helper = Helper::getInstance();
        /**
         * Update cache - first try using fopen and then cURL
    Severity: Minor
    Found in class/HeadlineRenderer.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method updateCache has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateCache()
    {
        $helper = Helper::getInstance();
        /**
         * Update cache - first try using fopen and then cURL
    Severity: Minor
    Found in class/HeadlineRenderer.php - About 1 hr to fix

      Method renderBlock has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function renderBlock(bool $force_update = false): bool
    {
        $retval = false;
        if ($force_update || $this->headline->cacheExpired()) {
            if (!$this->updateCache()) {
      Severity: Minor
      Found in class/HeadlineRenderer.php - About 1 hr to fix

        Function renderBlock has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function renderBlock(bool $force_update = false): bool
    {
        $retval = false;
        if ($force_update || $this->headline->cacheExpired()) {
            if (!$this->updateCache()) {
        Severity: Minor
        Found in class/HeadlineRenderer.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function &_parse(): bool
    {
        $retval = true;
        if (!isset($this->parser)) {
            require_once XOOPS_ROOT_PATH . '/class/xml/rss/xmlrss2parser.php';
        Severity: Minor
        Found in class/HeadlineRenderer.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getErrors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function &getErrors(bool $ashtml = true)
    {
        if ($ashtml) {
            $retval = '';
            if (\count($this->errors) > 0) {
        Severity: Minor
        Found in class/HeadlineRenderer.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status