Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
datawinners/common/authorization.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function view_or_basicauth has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

def view_or_basicauth(view, request, is_authenticated_func, authenticate_func, realm="", *args, **kwargs):
    """
    This is a helper function used by both 'logged_in_or_basicauth' and
    'has_perm_or_basicauth' that does the nitty of determining if they
    are already logged in or if they have provided proper http-authorization
Severity: Minor
Found in datawinners/common/authorization.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function view_or_basicauth has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def view_or_basicauth(view, request, is_authenticated_func, authenticate_func, realm="", *args, **kwargs):
Severity: Major
Found in datawinners/common/authorization.py - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if user.is_active:
                        login(request, user)
                        request.user = user
                        return view(request, *args, **kwargs)
    Severity: Major
    Found in datawinners/common/authorization.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status