Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
datawinners/entity/import_data.py

Summary

Maintainability
F
3 days
Test Coverage

File import_data.py has 450 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# vim: ai ts=4 sts=4 et sw=4 encoding=utf-8
import os
import logging
import re
Severity: Minor
Found in datawinners/entity/import_data.py - About 6 hrs to fix

    Function _import_submission has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def _import_submission(self, organization, values, form_model=None):
        self._append_country_for_location_field(form_model, values, organization)
        sid = transaction.savepoint()
        try:
            if filter(lambda x: len(x), values.values()).__len__() == 0:
    Severity: Minor
    Found in datawinners/entity/import_data.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function translate_errors has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def translate_errors(items, question_dict={}, question_answer_dict={}):
    errors = []
    for key, value in items:

        answer, question_label = _get_answer_and_question_label(question_answer_dict, question_dict, key)
    Severity: Minor
    Found in datawinners/entity/import_data.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _import_data_sender has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def _import_data_sender(self, form_model, organization, values):
        try:
            mobile_number = case_insensitive_lookup(values, "m")

            if not mobile_number:
    Severity: Minor
    Found in datawinners/entity/import_data.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function tabulate_failures has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def tabulate_failures(rows, manager):
    tabulated_data = []
    form_model = None
    questions_dict = {}
    Severity: Minor
    Found in datawinners/entity/import_data.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _handle_uploaded_file has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _handle_uploaded_file(file_name, file, manager, default_parser=None, form_code=None, is_datasender=False,
    Severity: Major
    Found in datawinners/entity/import_data.py - About 50 mins to fix

      Function import_data has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def import_data(request, manager, default_parser=None, form_code=None, is_datasender=False, is_update=False):
      Severity: Minor
      Found in datawinners/entity/import_data.py - About 45 mins to fix

        Function import_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def import_data(request, manager, default_parser=None, form_code=None, is_datasender=False, is_update=False):
    response_message = ''
    error_message = None
    failure_imports = None
    imported_entities = []
        Severity: Minor
        Found in datawinners/entity/import_data.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function build has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def build(cls, manager, extension, default_parser=None, form_code=None, is_datasender=False, is_update=False):
        Severity: Minor
        Found in datawinners/entity/import_data.py - About 45 mins to fix

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, dbm, parser, channel_name, location_tree=None, is_datasender=False, is_update=False):
          Severity: Minor
          Found in datawinners/entity/import_data.py - About 45 mins to fix

            Function send_email_to_data_sender has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def send_email_to_data_sender(user, language_code, request=None, type="activation", organization=None):
            Severity: Minor
            Found in datawinners/entity/import_data.py - About 35 mins to fix

              Function send_email_to_data_sender has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def send_email_to_data_sender(user, language_code, request=None, type="activation", organization=None):
    site = get_current_site(request)
    account_type = organization.account_type if organization else 'Pro SMS'
    ctx_dict = {
        'domain': site.domain,
              Severity: Minor
              Found in datawinners/entity/import_data.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function build has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def build(cls, manager, extension, default_parser=None, form_code=None, is_datasender=False, is_update=False):
        channels = dict({".xls": Channel.XLS, ".xlsx": Channel.XLSX, ".csv": Channel.CSV})
        try:
            channel = channels[extension]
        except KeyError:
              Severity: Minor
              Found in datawinners/entity/import_data.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if is_reporter:
                msg = _("%s with Unique ID Number = %s already exists.") % (e.data[2], e.data[1]) \
                    if e.data[0] == 'Unique ID Number' \
                    else _("%s with %s = %s already exists.") % (e.data[2], e.data[0], e.data[1])
              Severity: Major
              Found in datawinners/entity/import_data.py and 1 other location - About 5 hrs to fix
              datawinners/entity/import_data.py on lines 188..196

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 92.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      elif 'shorter' in value:
            errors.append(_("Answer %s for question %s is shorter than allowed.") % ((answer).split(".0")[0], question_label))
              Severity: Minor
              Found in datawinners/entity/import_data.py and 1 other location - About 40 mins to fix
              datawinners/entity/import_data.py on lines 289..290

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      elif 'longer' in value:
            errors.append(_("Answer %s for question %s is longer than allowed.") % ((answer).split(".0")[0], question_label))
              Severity: Minor
              Found in datawinners/entity/import_data.py and 1 other location - About 40 mins to fix
              datawinners/entity/import_data.py on lines 304..305

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status