Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
datawinners/scheduler/vumiclient.py

Summary

Maintainability
C
1 day
Test Coverage

File vumiclient.py has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import re
import urllib
import urllib2
import base64
Severity: Minor
Found in datawinners/scheduler/vumiclient.py - About 3 hrs to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, url, method, data=None, headers={},\
    Severity: Minor
    Found in datawinners/scheduler/vumiclient.py - About 45 mins to fix

      Function dict_to_tuple has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def dict_to_tuple(dictionary):
    """

    >>> dict_to_tuple({'id':[1,2,3,4],'testing':1,'bla':'three'})
    [('testing', 1), ('bla', 'three'), ('id', 1), ('id', 2), ('id', 3), ('id', 4)]
      Severity: Minor
      Found in datawinners/scheduler/vumiclient.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function auto_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def auto_response(function):
    """
    A decorator, it'll automatically convert a dictionary into
    proper python objects and it'll create namedtuple instances
    for each of the objects using the camelcased name of the
      Severity: Minor
      Found in datawinners/scheduler/vumiclient.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function process_types has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def process_types(dictionary):
    """
    Process a dictionary's values according to types as defined in
    TYPE_CAST_MAP
      Severity: Minor
      Found in datawinners/scheduler/vumiclient.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @auto_response
    def get_status_by_id(self, **kwargs):
        """
        Get the status of SMSs sent by their ids::
      Severity: Major
      Found in datawinners/scheduler/vumiclient.py and 1 other location - About 1 hr to fix
      datawinners/scheduler/vumiclient.py on lines 294..307

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @auto_response
    def get_status_since(self, **kwargs):
        """
        Get the status of SMSs sent since a specific date::
      Severity: Major
      Found in datawinners/scheduler/vumiclient.py and 1 other location - About 1 hr to fix
      datawinners/scheduler/vumiclient.py on lines 309..322

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status