Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
func_tests/pages/allsubjectspage/all_subject_type_page.py

Summary

Maintainability
C
1 day
Test Coverage

AllSubjectTypePage has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class AllSubjectTypePage(Page):
    def __init__(self, driver):
        Page.__init__(self, driver)

    def navigate_to_add_a_subject_page(self):
Severity: Minor
Found in func_tests/pages/allsubjectspage/all_subject_type_page.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def actions_menu_shown_for(self, subject_type):
        subject_number = self.get_subject_type_number(subject_type)
        return self.driver.find(by_id("action%s" % str(subject_number))).is_displayed()
    Severity: Major
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 1 other location - About 1 hr to fix
    func_tests/pages/allsubjectspage/all_subject_type_page.py on lines 103..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def is_none_selected_shown_for(self, subject_type):
        subject_number = self.get_subject_type_number(subject_type)
        return self.driver.find(by_id("none-selected%s" % str(subject_number))).is_displayed()
    Severity: Major
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 1 other location - About 1 hr to fix
    func_tests/pages/allsubjectspage/all_subject_type_page.py on lines 107..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        def get_cell_value(self, row, column):
        # first row is used to show all rows select message
        return self.driver.find(by_xpath(".//*[@id='subjects_table']/tbody/tr[%s]/td[%s]" % ((row + 1), column))).text
    Severity: Major
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 3 other locations - About 1 hr to fix
    func_tests/pages/alldatasenderspage/all_data_senders_page.py on lines 269..271
    func_tests/pages/submissionlogpage/submission_log_page.py on lines 95..96
    func_tests/pages/submissionlogpage/submission_log_page.py on lines 169..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def is_checkall_checked_for_entity_type(self, entity_type):
        return self.driver.find(by_css(CHECKALL_CB % entity_type)).get_attribute("checked") == "true"
    Severity: Major
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 1 other location - About 1 hr to fix
    func_tests/pages/alldatasenderspage/all_data_senders_page.py on lines 216..217

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def check_subject_type_on_page(self, subject):
        """
        Function to check the subject type on the all subject page of the website

        Return true or false
    Severity: Major
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 1 other location - About 1 hr to fix
    func_tests/pages/addsubjecttypepage/add_subject_type_page.py on lines 36..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def search_with(self, search_text):
        self.driver.find_text_box(by_css("div#subjects_table_filter input")).enter_text(search_text)
        self.wait_for_table_data_to_load()
    Severity: Minor
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 1 other location - About 45 mins to fix
    func_tests/pages/submissionlogpage/submission_log_page.py on lines 142..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        def navigate_to_add_a_subject_page(self):
        """
        Function to navigate to add a subject page of the website

        Return create project page
    Severity: Major
    Found in func_tests/pages/allsubjectspage/all_subject_type_page.py and 7 other locations - About 35 mins to fix
    func_tests/pages/activateaccountpage/activate_account_page.py on lines 33..41
    func_tests/pages/alldatasenderspage/all_data_senders_page.py on lines 19..26
    func_tests/pages/globalnavigationpage/global_navigation_page.py on lines 39..46
    func_tests/pages/globalnavigationpage/global_navigation_page.py on lines 57..64
    func_tests/pages/loginpage/login_page.py on lines 82..89
    func_tests/pages/projectdatasenderspage/project_data_senders_page.py on lines 28..33
    func_tests/pages/reviewpage/review_page.py on lines 116..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status