Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
func_tests/pages/loginpage/login_page.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def login(driver, credential=VALID_CREDENTIALS, landing_page=None):

    LoginPage(driver).load(landing_page).login_with(credential)
    if not landing_page:
        try:
Severity: Minor
Found in func_tests/pages/loginpage/login_page.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def get_error_message(self):
        """
        Function to fetch the error messages from error label of the login
        page
Severity: Major
Found in func_tests/pages/loginpage/login_page.py and 1 other location - About 2 hrs to fix
func_tests/pages/expiredtrialpage/expired_trial_page.py on lines 8..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    def navigate_to_registration_page(self):
        """
        Function to click on register page link which is available on the login page

        Return RegistrationPage
Severity: Major
Found in func_tests/pages/loginpage/login_page.py and 7 other locations - About 35 mins to fix
func_tests/pages/activateaccountpage/activate_account_page.py on lines 33..41
func_tests/pages/alldatasenderspage/all_data_senders_page.py on lines 19..26
func_tests/pages/allsubjectspage/all_subject_type_page.py on lines 18..25
func_tests/pages/globalnavigationpage/global_navigation_page.py on lines 39..46
func_tests/pages/globalnavigationpage/global_navigation_page.py on lines 57..64
func_tests/pages/projectdatasenderspage/project_data_senders_page.py on lines 28..33
func_tests/pages/reviewpage/review_page.py on lines 116..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status