Sign upLogin

mangroveorg/datawinners

View on GitHub
Star
func_tests/pages/reviewpage/review_page.py

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def navigate_to_project_overview_page(self):
        """
        Function to navigate to project overview page of the website

        Return project_overview_page
Severity: Major
Found in func_tests/pages/reviewpage/review_page.py and 2 other locations - About 50 mins to fix
func_tests/pages/lightbox/light_box_page.py on lines 10..19
func_tests/pages/questionnairetabpage/questionnaire_tab_page.py on lines 362..372

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    def open_sms_tester_light_box(self):
        """
        Function to open the sms tester light box

        return SMSTesterLightBoxPage
Severity: Major
Found in func_tests/pages/reviewpage/review_page.py and 7 other locations - About 35 mins to fix
func_tests/pages/activateaccountpage/activate_account_page.py on lines 33..41
func_tests/pages/alldatasenderspage/all_data_senders_page.py on lines 19..26
func_tests/pages/allsubjectspage/all_subject_type_page.py on lines 18..25
func_tests/pages/globalnavigationpage/global_navigation_page.py on lines 39..46
func_tests/pages/globalnavigationpage/global_navigation_page.py on lines 57..64
func_tests/pages/loginpage/login_page.py on lines 82..89
func_tests/pages/projectdatasenderspage/project_data_senders_page.py on lines 28..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status