Sign upLogin

marekkirejczyk/ethereum.rb

View on GitHub
Star
lib/ethereum/contract.rb

Summary

Maintainability
D
2 days
Test Coverage

Method create has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    def self.create(file: nil, client: Ethereum::Singleton.instance, code: nil, abi: nil, address: nil, name: nil, contract_index: nil, truffle: nil)
      contract = nil
      if file.present?
        contracts = Ethereum::Initializer.new(file, client).build_all
        raise "No contracts compiled" if contracts.empty?
Severity: Minor
Found in lib/ethereum/contract.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Contract has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Contract

    attr_reader :address
    attr_accessor :key
    attr_accessor :gas_limit, :gas_price, :nonce
Severity: Minor
Found in lib/ethereum/contract.rb - About 3 hrs to fix

    File contract.rb has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'forwardable'

module Ethereum
  class Contract
    Severity: Minor
    Found in lib/ethereum/contract.rb - About 2 hrs to fix

      Method create has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.create(file: nil, client: Ethereum::Singleton.instance, code: nil, abi: nil, address: nil, name: nil, contract_index: nil, truffle: nil)
      contract = nil
      if file.present?
        contracts = Ethereum::Initializer.new(file, client).build_all
        raise "No contracts compiled" if contracts.empty?
      Severity: Minor
      Found in lib/ethereum/contract.rb - About 1 hr to fix

        Method build has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def build
      class_name = @name.camelize
      parent = self
      create_function_proxies
      create_event_proxies
        Severity: Minor
        Found in lib/ethereum/contract.rb - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                        address = if client
                          network_id = client.net_version['result']
                          (artifacts['networks'][network_id]) ? artifacts['networks'][network_id]['address'] : nil
                        else
                          nil
          Severity: Major
          Found in lib/ethereum/contract.rb - About 45 mins to fix

            There are no issues that match your filters.

            Category
            Status