Sign upLogin

mariuz/firebirdwebadmin

View on GitHub
Star
inc/session.inc.php

Summary

Maintainability
D
2 days
Test Coverage

Method initialize_session has 205 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function initialize_session()
{
    global $ptitle_strings, $adm_strings;

    $session_vars =
Severity: Major
Found in inc/session.inc.php - About 1 day to fix

    File session.inc.php has 419 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
// File           session.inc.php / FirebirdWebAdmin
// Purpose        session and fallback related functions, define all session variables
// Author         Lutz Brueckner <irie@gmx.de>
// Copyright      (c) 2000-2006 by Lutz Brueckner,
    Severity: Minor
    Found in inc/session.inc.php - About 6 hrs to fix

      Method globalize_session_vars has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function globalize_session_vars()
{
    $session_var_names =
        array('s_init',
              's_cookies',
      Severity: Major
      Found in inc/session.inc.php - About 3 hrs to fix

        Method cleanup_session has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function cleanup_session()
{
    $GLOBALS['s_modify_table'] = '';
    $GLOBALS['s_enter_name'] = '';
    $GLOBALS['s_tables'] = array();
        Severity: Major
        Found in inc/session.inc.php - About 2 hrs to fix

          Consider simplifying this complex logical expression.
          Open

              if ((!isset($_COOKIE[SESSION_NAME])  &&
         !isset($_POST[SESSION_NAME])  &&
         !isset($_GET[SESSION_NAME])
         )  ||
        (PROTOCOL == 'https'  &&  !isset($_SERVER['HTTPS'])  &&
          Severity: Major
          Found in inc/session.inc.php - About 1 hr to fix

            Function initialize_session has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            function initialize_session()
{
    global $ptitle_strings, $adm_strings;

    $session_vars =
            Severity: Minor
            Found in inc/session.inc.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          's_database_panels' => array(array('db_login',   $ptitle_strings['db_login'],   'open'),
                                           array('db_create',  $ptitle_strings['db_create'],  'close'),
                                           array('db_delete',  $ptitle_strings['db_delete'],  'close'),
                                           array('db_systable',$ptitle_strings['db_systable'],'close'),
                                           array('db_meta',    $ptitle_strings['db_meta'],    'close'), ),
            Severity: Minor
            Found in inc/session.inc.php and 1 other location - About 30 mins to fix
            inc/session.inc.php on lines 315..319

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          's_admin_panels' => array(array('adm_server',$ptitle_strings['adm_server'],'open'),
                                             array('adm_dbstat',$ptitle_strings['adm_dbstat'],'close'),
                                             array('adm_gfix',  $ptitle_strings['adm_gfix'],  'close'),
                                             array('adm_backup',$ptitle_strings['adm_backup'],'close'),
                                             array('adm_restore',$ptitle_strings['adm_restore'],'close'), ),
            Severity: Minor
            Found in inc/session.inc.php and 1 other location - About 30 mins to fix
            inc/session.inc.php on lines 278..282

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status