Sign upLogin

marksmall/node-build-web-app

View on GitHub
Star

Showing 68 of 68 total issues

Function registerTask has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    registerTask(gulp){
        super.registerTask(gulp);

        gulp.task("styles-vendor-dist", "Optimize and minimize vendor stylesheets for production", () =>{
            // If the app src folder is overridden, then append it to the watch list, otherwise use default.
Severity: Minor
Found in src/gulp/tasks/styles-vendor-dist.js - About 1 hr to fix

Function registerTasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    registerTasks(inputGulp, inputOptions){
        let gulp = inputGulp || require("gulp"); // this module can be imported without a defined gulp instance
        let options = inputOptions || {};

        gulp = utils.configureGulpObject(gulp, options); // we need to customize the gulp object a bit
Severity: Minor
Found in src/index.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        gulp.task("validate-package-json", "Validate the package.json file", () =>{
            return gulp.plumbedSrc(config.files.packageJSON)
                .pipe(packageJsonValidator());
        });
Severity: Minor
Found in src/gulp/tasks/validate-package-json.js and 1 other location - About 40 mins to fix
gulp/tasks/validate-package-json.js on lines 11..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task("validate-package-json", "Validate the package.json file", () =>{
    return utils.plumbedSrc(config.files.packageJSON)
        .pipe(packageJsonValidator());
});
Severity: Minor
Found in gulp/tasks/validate-package-json.js and 1 other location - About 40 mins to fix
src/gulp/tasks/validate-package-json.js on lines 13..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task("test-unit", "Execute all unit tests", (callback) =>{
    return new KarmaServer({
        configFile: karmaConfigFilePath, // necessary otherwise the file is not resolved correctly
        singleRun: true
    }, callback).start();
Severity: Minor
Found in gulp/tasks/test-unit.js and 1 other location - About 35 mins to fix
gulp/tasks/test-unit.js on lines 23..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

gulp.task("test-unit-dev", "Execute all unit tests continuously (watches files)", (callback) =>{
    return new KarmaServer({
        configFile: karmaConfigFilePath, // necessary otherwise the file is not resolved correctly
        singleRun: false
    }, callback).start();
Severity: Minor
Found in gulp/tasks/test-unit.js and 1 other location - About 35 mins to fix
gulp/tasks/test-unit.js on lines 16..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        let middleware = [
            historyApiFallback(), // not necessary if the app uses hash based routing
            function(req, res, next){
                res.setHeader("Access-Control-Allow-Origin", "*"); // add CORS to the response headers (for resources served by BrowserSync)
                next();
Severity: Minor
Found in src/gulp/tasks/serve.js and 1 other location - About 30 mins to fix
src/gulp/tasks/serve-dist.js on lines 25..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        let middleware = [
            historyApiFallback(), // not necessary if the app uses hash based routing
            function(req, res, next){
                res.setHeader("Access-Control-Allow-Origin", "*"); // add CORS to the response headers (for resources served by BrowserSync)
                next();
Severity: Minor
Found in src/gulp/tasks/serve-dist.js and 1 other location - About 30 mins to fix
src/gulp/tasks/serve.js on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function mergeOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

let mergeOptions = (obj1 = {}, obj2 = {}) =>{
    let retVal = {};

    for(let attrname in obj1){
        if(obj1.hasOwnProperty(attrname)){
Severity: Minor
Found in src/gulp/utils.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import gulp from "gulp";
Severity: Minor
Found in examples/gulpfile.babel.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/tasks/clean.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/tasks/html.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/tasks/scripts-javascript.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/tasks/serve.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

export default {
Severity: Minor
Found in examples/api/search.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/tasks/styles-dist.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import gulp from "gulp";
Severity: Minor
Found in gulp/tasks/clean.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import requireDir from "require-dir";
Severity: Minor
Found in gulpfile.babel.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

export default {
Severity: Minor
Found in examples/api/tools.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
Open

import AbstractTaskLoader from "../abstractTaskLoader";
Severity: Minor
Found in src/gulp/templates/taskLoaderTemplate.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Severity
Category
Status
Source
Language