Sign upLogin

matteoferla/Fragmenstein

View on GitHub
Star
fragmenstein/victor/minimalPDB.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function parse has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    def parse(self, block:str) -> None:
        # ---- parse -----------------------------------------
        if block.find('\n') == -1:
            raise ValueError(f'No newline found in block: Is {block} a filename?')
        def starts_with(xrow, name): return xrow.find(name) == 0
Severity: Minor
Found in fragmenstein/victor/minimalPDB.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if resType in self.water_resnames:
                            continue
                self.step = 1
Severity: Major
Found in fragmenstein/victor/minimalPDB.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if resType not in self.to_preserve_heteroResname:
                            continue
                    if self.remove_water:
    Severity: Major
    Found in fragmenstein/victor/minimalPDB.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status