matteolc/t2_airtime

View on GitHub
lib/t2_airtime/api.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method topup has 17 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def topup(msisdn, destination_msisdn, product, method = 'topup',
              reserved_id = nil, send_sms = true, sms = nil, sender_text = nil,
              cid1 = '', cid2 = '', cid3 = '',
              operator_id = nil,
              return_service_fee = 1, delivered_amount_info = 1, return_timestamp = 1, return_version = 1,
Severity: Major
Found in lib/t2_airtime/api.rb - About 2 hrs to fix

    Method msisdn_info has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def msisdn_info(destination_msisdn,
                        operator_id = nil,
                        delivered_amount_info = 1, return_service_fee = 1, return_promo = 1)
    Severity: Minor
    Found in lib/t2_airtime/api.rb - About 35 mins to fix

      Method transaction_list has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def transaction_list(start = (Time.now - 24.hours), stop = Time.now, msisdn = nil, destination = nil, code = nil)
      Severity: Minor
      Found in lib/t2_airtime/api.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status