Sign upLogin

medialize/ally.js

View on GitHub
Star

Showing 736 of 736 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

      var decorated = decorateService({
        engage: function() {
          engaged = true;
        },
        disengage: function() {
Severity: Major
Found in test/unit/util.decorate-service.test.js and 3 other locations - About 35 mins to fix
test/unit/util.decorate-service.test.js on lines 11..18
test/unit/util.decorate-service.test.js on lines 93..100
test/unit/util.decorate-service.test.js on lines 114..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var expected = [
          !platform.is.IOS && 'div',
          !platform.is.IOS && '#link',
        ].filter(Boolean);
Severity: Minor
Found in test/unit/query.tabsequence.test.js and 1 other location - About 35 mins to fix
test/unit/query.tabsequence.sort-area.test.js on lines 147..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var expected = [
          !platform.is.IOS && '#image-map-area',
          !platform.is.IOS && '#image-map-area-2',
        ].filter(Boolean);
Severity: Minor
Found in test/unit/query.tabsequence.sort-area.test.js and 1 other location - About 35 mins to fix
test/unit/query.tabsequence.test.js on lines 138..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  _current.forEach(function(element) {
    if (elements.indexOf(element) !== -1) {
      return;
    }
Severity: Minor
Found in src/style/focus-within.js and 1 other location - About 35 mins to fix
src/style/focus-within.js on lines 56..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  elements.forEach(function(element) {
    if (_current.indexOf(element) !== -1) {
      return;
    }
Severity: Minor
Found in src/style/focus-within.js and 1 other location - About 35 mins to fix
src/style/focus-within.js on lines 47..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return true;
Severity: Major
Found in src/is/focus-relevant.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return true;
    Severity: Major
    Found in src/is/tabbable.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return hasTabbableTabindexOrNone;
      Severity: Major
      Found in src/is/tabbable.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return true;
        Severity: Major
        Found in src/is/tabbable.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return hasTabbableTabindex;
          Severity: Major
          Found in src/is/tabbable.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return -1;
            Severity: Major
            Found in build/metalsmith/plugins/collection.manual-sort.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return -1;
              Severity: Major
              Found in build/metalsmith/plugins/collection.manual-sort.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return true;
                Severity: Major
                Found in src/is/tabbable.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return false;
                  Severity: Major
                  Found in src/is/tabbable.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return false;
                    Severity: Major
                    Found in src/is/focus-relevant.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return true;
                      Severity: Major
                      Found in src/is/focus-relevant.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return true;
                        Severity: Major
                        Found in src/is/focus-relevant.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return true;
                          Severity: Major
                          Found in src/is/focus-relevant.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return false;
                            Severity: Major
                            Found in src/is/focus-relevant.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return true;
                              Severity: Major
                              Found in src/is/focus-relevant.js - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language