Sign upLogin

melphi/algobox

View on GitHub
Star

Showing 255 of 255 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_should_get_frame_end_15m_infra_bar(self):
        expected = int(
            datetime(2016, 1, 12, 9, 14, 59, 999999).timestamp() * 1000.0)
        actual = TimestampUtil.get_frame_end(
            self._DEFAULT_TIMESTAMP_INFRA, StandardTimeFrame.M15)
Severity: Major
Found in python/algobox/src/tests/algobox/util/test_dateutil.py and 2 other locations - About 2 hrs to fix
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 43..48
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 50..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_should_get_frame_end_15m_at_open(self):
        expected = int(
            datetime(2016, 1, 12, 9, 14, 59, 999999).timestamp() * 1000.0)
        actual = TimestampUtil.get_frame_end(
            self._DEFAULT_TIMESTAMP_OPEN, StandardTimeFrame.M15)
Severity: Major
Found in python/algobox/src/tests/algobox/util/test_dateutil.py and 2 other locations - About 2 hrs to fix
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 36..41
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 50..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_should_get_frame_end_15m_at_close(self):
        expected = int(
            datetime(2016, 1, 12, 9, 14, 59, 999999).timestamp() * 1000.0)
        actual = TimestampUtil.get_frame_end(
            self._DEFAULT_TIMESTAMP_CLOSE, StandardTimeFrame.M15)
Severity: Major
Found in python/algobox/src/tests/algobox/util/test_dateutil.py and 2 other locations - About 2 hrs to fix
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 36..41
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_should_get_frame_start_15m_at_close(self):
        expected = int(
            datetime(2016, 1, 12, 9, 0, 0).timestamp() * 1000.0)
        actual = TimestampUtil.get_frame_start(
            self._DEFAULT_TIMESTAMP_CLOSE, StandardTimeFrame.M15)
Severity: Major
Found in python/algobox/src/tests/algobox/util/test_dateutil.py and 2 other locations - About 2 hrs to fix
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 15..20
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 22..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_should_get_frame_start_15m_at_open(self):
        expected = int(
            datetime(2016, 1, 12, 9, 0, 0).timestamp() * 1000.0)
        actual = TimestampUtil.get_frame_start(
            self._DEFAULT_TIMESTAMP_OPEN, StandardTimeFrame.M15)
Severity: Major
Found in python/algobox/src/tests/algobox/util/test_dateutil.py and 2 other locations - About 2 hrs to fix
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 15..20
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 29..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def test_should_get_frame_start_15m_infra_bar(self):
        expected = int(
            datetime(2016, 1, 12, 9, 0, 0).timestamp() * 1000.0)
        actual = TimestampUtil.get_frame_start(
            self._DEFAULT_TIMESTAMP_INFRA, StandardTimeFrame.M15)
Severity: Major
Found in python/algobox/src/tests/algobox/util/test_dateutil.py and 2 other locations - About 2 hrs to fix
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 22..27
python/algobox/src/tests/algobox/util/test_dateutil.py on lines 29..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function marked has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function marked(src, opt, callback) {
  if (callback || typeof opt === 'function') {
    if (!callback) {
      callback = opt;
      opt = null;
Severity: Major
Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/marked.js - About 2 hrs to fix

    PriceOhlcCacheMdb has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public final class PriceOhlcCacheMdb implements Ohlc {
  public static final String COLLECTION_PRICE_OHLC_CACHE = "priceOhlcCache";
  public static final String FIELD_INSTRUMENT = "instrument";
  public static final String FIELD_FROM_TIME = "fromTime";
  public static final String FIELD_TO_TIME = "toTime";
    Severity: Minor
    Found in java/algobox/algobox-api/src/main/java/io/algobox/api/module/indicator/domain/mdb/PriceOhlcCacheMdb.java - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                      if (match) {
                    // parse months, days, hours, minutes, seconds, and milliseconds
                    // provide default values if necessary
                    // parse the UTC offset component
                    var year = $Number(match[1]),
      Severity: Critical
      Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/es5-shim.js - About 2 hrs to fix

        File plot.py has 271 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        from algobox.analysis.indicator import OhlcIndicators
from algobox.price import StandardTimeFrame
from algobox.price.pricefactory import PriceFactory
from algobox.util.preconditions import Preconditions
from datetime import datetime
        Severity: Minor
        Found in python/algobox/src/algobox/analysis/plot.py - About 2 hrs to fix

          Function toFixed has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var toFixedShim = function toFixed(fractionDigits) {
        var f, x, s, m, e, z, j, k;

        // Test for NaN and round fractionDigits down
        f = $Number(fractionDigits);
          Severity: Major
          Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/es5-shim.js - About 2 hrs to fix

            Function splice has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    splice: function splice(start, deleteCount) {
            var O = ES.ToObject(this);
            var A = [];
            var len = ES.ToUint32(O.length);
            var relativeStart = ES.ToInteger(start);
            Severity: Major
            Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/es5-shim.js - About 2 hrs to fix

              Function split has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          StringPrototype.split = function (separator, limit) {
                var string = String(this);
                if (typeof separator === 'undefined' && limit === 0) {
                    return [];
                }
              Severity: Major
              Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/es5-shim.js - About 2 hrs to fix

                ConnectorServiceImpl has 21 methods (exceeds 20 allowed). Consider refactoring.
                Open

                public final class ConnectorServiceImpl implements ConnectorService {
  private static final Logger LOGGER = LoggerFactory.getLogger(ConnectorServiceImpl.class);
  private static final long TRY_CONNECTION_POLLING_MILLISECONDS = 1_500L;
  private static final long MARKET_HOURS_POLLING_MILLISECONDS = 60_000L;
                Severity: Minor
                Found in java/algobox/algobox-connectors/src/main/java/io/algobox/connector/service/impl/ConnectorServiceImpl.java - About 2 hrs to fix

                  Function onOAuthComplete has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  window.onOAuthComplete = function onOAuthComplete(token,OAuthSchemeKey) {
  if(token) {
    if(token.error) {
      var checkbox = $('input[type=checkbox],.secured')
      checkbox.each(function(pos){
                  Severity: Major
                  Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/swagger-oauth.js - About 2 hrs to fix

                    Method getMarketHours24HoursMarket has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      public static Optional<MarketHours> getMarketHours24HoursMarket(
      InstrumentInfoDetailed info, ZonedDateTime localDateTime) {
    checkArgument(localDateTime.getZone().getId().equals(info.getTimeZoneId()));
    checkArgument(Objects.equals(info.getOpenHour(), info.getCloseHour()) &&
            Objects.equals(info.getOpenMinute(), info.getCloseMinute()),
                    Severity: Major
                    Found in java/algobox/algobox-core/src/main/java/io/algobox/util/MarketHoursUtils.java - About 2 hrs to fix

                      Function setupParams has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            setupParams: function setupParams(helper, paramSize, params) {
        var options = {},
            contexts = [],
            types = [],
            ids = [],
                      Severity: Major
                      Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/handlebars-4.0.5.js - About 2 hrs to fix

                        Function mergeSource has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              mergeSource: function mergeSource(varDeclarations) {
        var isSimple = this.environment.isSimple,
            appendOnly = !this.forceBuffer,
            appendFirst = undefined,
            sourceSeen = undefined,
                        Severity: Minor
                        Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/handlebars-4.0.5.js - About 2 hrs to fix

                          Consider simplifying this complex logical expression.
                          Open

                                              if (
                        hour < (hasMinutesOrSecondsOrMilliseconds ? 24 : 25) &&
                        minute < 60 && second < 60 && millisecond < 1000 &&
                        month > -1 && month < 12 && hourOffset < 24 &&
                        minuteOffset < 60 && // detect invalid offsets
                          Severity: Critical
                          Found in java/algobox/algobox-microservice/src/main/resources/static/swagger/lib/es5-shim.js - About 2 hrs to fix

                            Cyclomatic complexity is too high in method day_overview. (7)
                            Open

                                def day_overview(self, *, instrument_id, date):
        """Returns an overview (plot and data) of the day.

        Args:
            instrument_id (str): The instrument id.
                            Severity: Minor
                            Found in python/algobox/src/algobox/analysis/main.py by radon

                            Cyclomatic Complexity

                            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                            Construct Effect on CC Reasoning
                            if +1 An if statement is a single decision.
                            elif +1 The elif statement adds another decision.
                            else +0 The else statement does not cause a new decision. The decision is at the if.
                            for +1 There is a decision at the start of the loop.
                            while +1 There is a decision at the while statement.
                            except +1 Each except branch adds a new conditional path of execution.
                            finally +0 The finally block is unconditionally executed.
                            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                            assert +1 The assert statement internally roughly equals a conditional statement.
                            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                            Source: http://radon.readthedocs.org/en/latest/intro.html

                            Severity
                            Category
                            Status
                            Source
                            Language