Showing 255 of 255 total issues
Cyclomatic complexity is too high in method get_price_ticks. (7) Open
def get_price_ticks(
self, instrument_id, from_timestamp, to_timestamp, **kwargs):
if instrument_id == TestingConstants.DEFAULT_INSTRUMENT_ID_DAX:
assert from_timestamp == _TestingClientConstants \
.DEFAULT_MARKET_HOURS_DAX.market_open- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Method run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
@Override
public void run() {
// TODO(robertom): Implement service shutdown hook.
while (true) {
ImmutableSet<String> connectorsId = ImmutableSet.copyOf(keepAliveConnections);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
def test_load_price_bars_date_numeric(self):
price_feed = LocalFilePriceFeed(
TestingConstants.DEFAULT_INSTRUMENT_ID_DAX,
TestingConstants.FILE_SAMPLE_DAX_TICKS_NUMERIC_DATE)
for price in price_feed.get_prices():- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 49.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
def test_load_price_bars_date_string(self):
price_feed = LocalFilePriceFeed(
TestingConstants.DEFAULT_INSTRUMENT_ID_DAX,
TestingConstants.FILE_SAMPLE_DAX_TICKS)
for price in price_feed.get_prices():- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 49.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Cyclomatic complexity is too high in method get_prices. (6) Open
def get_prices(self):
"""Reads the file and returns a collection of prices.
Returns:
generator of PriceTick- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in method build. (6) Open
def build(self, axes):
super().build(axes)
max = self._ohlc_matrix.index.max().value
min = self._ohlc_matrix.index.min().value
bar_width = (max - min) / self._ohlc_matrix.shape[0]- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
| Construct | Effect on CC | Reasoning |
|---|---|---|
| if | +1 | An if statement is a single decision. |
| elif | +1 | The elif statement adds another decision. |
| else | +0 | The else statement does not cause a new decision. The decision is at the if. |
| for | +1 | There is a decision at the start of the loop. |
| while | +1 | There is a decision at the while statement. |
| except | +1 | Each except branch adds a new conditional path of execution. |
| finally | +0 | The finally block is unconditionally executed. |
| with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
| assert | +1 | The assert statement internally roughly equals a conditional statement. |
| Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
| Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Method equals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function next has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
next: function next() {
if (this.done) {
return this.EOF;
}
if (!this._input) this.done = true;Method registerStrategy has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
private String registerStrategy(StrategyRegistration registration) {
Class<? extends Strategy> strategyClass =
strategyManager.getStrategyById(registration.getStrategyId());
checkNotNull(strategyClass, String.format(
"Strategy [%s] is not registered.", registration.getStrategyId()));Function parse has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
var parseShim = function parse(string) {
var match = isoDateExpression.exec(string);
if (match) {
// parse months, days, hours, minutes, seconds, and milliseconds
// provide default values if necessaryMethod loadStrategies has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
@SuppressWarnings("unchecked")
private Map<String, Class<? extends Strategy>> loadStrategies(
String strategiesJarPath, boolean loadDummyByDefault) throws Exception {
checkArgument(strategiesJarPath.startsWith("/"),
String.format("Strategies jar folder [%s] should start with /.", strategiesJarPath));Function PartialBlockStatement has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
WhitespaceControl.prototype.BlockStatement = WhitespaceControl.prototype.DecoratorBlock = WhitespaceControl.prototype.PartialBlockStatement = function (block) {
this.accept(block.program);
this.accept(block.inverse);
// Find the inverse program that is involed with whitespace stripping.Function Program has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
WhitespaceControl.prototype.Program = function (program) {
var doStandalone = !this.options.ignoreStandalone;
var isRoot = !this.isRootSeen;
this.isRootSeen = true;Method getMarketHoursLocalMarket has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static Optional<MarketHours> getMarketHoursLocalMarket(
InstrumentInfoDetailed info, ZonedDateTime localDateTime) {
checkArgument(localDateTime.getZone().getId().equals(info.getTimeZoneId()));
ZonedDateTime previousDayDateTime = localDateTime.minusDays(1);
switch (localDateTime.getDayOfWeek()) {Method tryEstablishConnection has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
private boolean tryEstablishConnection() {
if (!connectorManager.isMarketOpen()) {
LOGGER.info(String.format("Market is not open, connection to [%s] skipped.", connectionId));
callback.ifPresent(value -> value.complete(true));
return true;Function bind has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
bind: function bind(that) { // .length is 1
// 1. Let Target be the this value.
var target = this;
// 2. If IsCallable(Target) is false, throw a TypeError exception.
if (!isCallable(target)) {Function compile has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function compile(input, options, env) {
if (options === undefined) options = {};
if (input == null || typeof input !== 'string' && input.type !== 'Program') {
throw new _exception2['default']('You must pass a string or Handlebars AST to Handlebars.compile. You passed ' + input);Method createParameterValues has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static Set<String> createParameterValues(ParameterValues values) {
checkNotNull(values.getParameterValuesType());
switch (values.getParameterValuesType()) {
case LIST:
checkNotNull(values.getValues(), "Parameter has null values.");Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
def __init__(self, instrument_id, time_frame, timestamp_utc, open_ask,Function prepareBlock has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
function prepareBlock(openBlock, program, inverseAndProgram, close, inverted, locInfo) {
if (close && close.path) {
validateClose(openBlock, close);
}