mesg-foundation/core

View on GitHub
container/container.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Container.Start has 124 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Container) Start(srv *service.Service, instanceHash, runnerHash, instanceEnvHash hash.Hash, instanceEnv []string, registerPayload []byte) (err error) {
    // delete the service's container on any error
    errorOccurred := true
    defer func() {
        if errorOccurred {
Severity: Major
Found in container/container.go - About 3 hrs to fix

    Method Container.Start has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *Container) Start(srv *service.Service, instanceHash, runnerHash, instanceEnvHash hash.Hash, instanceEnv []string, registerPayload []byte) (err error) {
        // delete the service's container on any error
        errorOccurred := true
        defer func() {
            if errorOccurred {
    Severity: Minor
    Found in container/container.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Container.Start has 15 return statements (exceeds 6 allowed).
    Open

    func (c *Container) Start(srv *service.Service, instanceHash, runnerHash, instanceEnvHash hash.Hash, instanceEnv []string, registerPayload []byte) (err error) {
        // delete the service's container on any error
        errorOccurred := true
        defer func() {
            if errorOccurred {
    Severity: Major
    Found in container/container.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status