Sign upLogin

metaminded/tabulatr2

View on GitHub
Star

Showing 626 of 626 total issues

Cyclomatic complexity for initialize is too high. [7/6]
Open

  def initialize(relation)
    @relation   = relation
    @base       = self.class.main_class rescue nil
    @base       ||= relation.respond_to?(:klass) ? relation.klass : relation
    @table_name = @base.table_name
Severity: Minor
Found in lib/tabulatr/data/data.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for apply_sorting is too high. [7/6]
Open

  def apply_sorting(sortparam)
    if sortparam.present?
      clname, orientation = sortparam.split(' ')
      if clname[':']
        splitted = clname.split(':')
Severity: Minor
Found in lib/tabulatr/data/sorting.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for compute_pagination is too high. [16.76/15]
Open

  def compute_pagination(page, pagesize)
    count = @relation.count
    count = count.count if count.is_a?(Hash)
    page ||= 1
    pagesize, page = pagesize.to_i, page.to_i
Severity: Minor
Found in lib/tabulatr/data/pagination.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for join_required_tables is too high. [16.31/15]
Open

  def join_required_tables(params)
    if params[:arguments].present?
      tt = (params[:arguments].split(",").select{|s| s[':']}.map do |s|
            s.split(':').first
          end.uniq.map(&:to_sym))
Severity: Minor
Found in lib/tabulatr/data/data.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Function updatePagination has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  updatePagination: function(currentPage){
    var $paginatorUl = $('.pagination[data-table='+ this.tableId +'] > ul');
    $paginatorUl.html(this.createResetButton());
    if(this.pageCount < 13){
      for(var i = 1; i <= this.pageCount; i++){
Severity: Minor
Found in app/assets/javascripts/tabulatr/_pagination.js - About 1 hr to fix

    Function insertTabulatrData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      insertTabulatrData: function(response){
    if (typeof response === "string")
      response = JSON.parse(response);

    var tableId = response.meta.table_id;
    Severity: Minor
    Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 1 hr to fix

      Assignment Branch Condition size for column is too high. [15.84/15]
      Open

        def column(name, opts = {}, &block)
    @table_columns ||= []
    sql_options = determine_sql(opts, main_class.quoted_table_name, name)
    opts = {
            sort_sql: sql_options[:sort_sql],
      Severity: Minor
      Found in lib/tabulatr/data/dsl.rb by rubocop

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Assignment Branch Condition size for apply_formats is too high. [15.65/15]
      Open

        def apply_formats(locals: {}, controller: nil)
    view = Tabulatr::Data::Proxy.new(locals: locals, controller: controller)
    return @relation.map do |record|
      view.record = record
      h = HashWithIndifferentAccess.new
      Severity: Minor
      Found in lib/tabulatr/data/formatting.rb by rubocop

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Method apply_sorting has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def apply_sorting(sortparam)
    if sortparam.present?
      clname, orientation = sortparam.split(' ')
      if clname[':']
        splitted = clname.split(':')
      Severity: Minor
      Found in lib/tabulatr/data/sorting.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if(table_obj.checkIfCheckboxesAreMarked()){
          $('#'+ tableId +' .tabulatr-wrench').removeClass('disabled');
        }else{
          $('#'+ tableId +' .tabulatr-wrench').addClass('disabled');
        }
      Severity: Major
      Found in app/assets/javascripts/tabulatr/_events.js and 1 other location - About 1 hr to fix
      app/assets/javascripts/tabulatr/_events.js on lines 118..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if(table_obj.checkIfCheckboxesAreMarked()){
        $('#'+ tableId +' .tabulatr-wrench').removeClass('disabled');
      }else{
        $('#'+ tableId +' .tabulatr-wrench').addClass('disabled');
      }
      Severity: Major
      Found in app/assets/javascripts/tabulatr/_events.js and 1 other location - About 1 hr to fix
      app/assets/javascripts/tabulatr/_events.js on lines 151..155

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method apply_filters has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def apply_filters(filter_params)
    default_filters = table_columns.map do |col|
      next if col.col_options.default_filter.nil?
      ["#{col.table_name}:#{col.name}", col.col_options.default_filter]
    end.compact.to_h
      Severity: Minor
      Found in lib/tabulatr/data/filtering.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid parameter lists longer than 5 parameters. [15/5]
      Open

        def initialize(klass, view,
      filter:              Tabulatr.filter,
      search:              Tabulatr.search,
      paginate:            Tabulatr.paginate,
      pagesize:            Tabulatr.pagesize,
      Severity: Minor
      Found in lib/tabulatr/renderer/renderer.rb by rubocop

      This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

      Function retrieveTableFromLocalStorage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Tabulatr.prototype.retrieveTableFromLocalStorage = function(response){
    try {
      var currentStorage = JSON.parse(localStorage[this.id]);
      if(currentStorage !== undefined){
        $('.pagination[data-table='+ this.id +'] a[data-page='+ response.meta.page +']');
      Severity: Minor
      Found in app/assets/javascripts/tabulatr/_storage.js - About 1 hr to fix

        Method data_for_table has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def data_for_table(params, locals: {}, default_order: nil, controller: nil, &block)

    @batch_actions = block if block_given?
    @controller    = controller
    @default_order = default_order
        Severity: Minor
        Found in lib/tabulatr/data/data.rb - About 1 hr to fix

          Similar blocks of code found in 10 locations. Consider refactoring.
          Open

                for(var i = 0; i < tabulatr_tables.length; i++){
        if(tabulatr_tables[i].id === tableId){
          table_obj = tabulatr_tables[i];
        }
      }
          Severity: Major
          Found in app/assets/javascripts/tabulatr/_events.js and 9 other locations - About 1 hr to fix
          app/assets/javascripts/tabulatr/_events.js on lines 11..15
          app/assets/javascripts/tabulatr/_events.js on lines 72..76
          app/assets/javascripts/tabulatr/_events.js on lines 96..100
          app/assets/javascripts/tabulatr/_events.js on lines 108..112
          app/assets/javascripts/tabulatr/_events.js on lines 131..135
          app/assets/javascripts/tabulatr/_events.js on lines 166..170
          app/assets/javascripts/tabulatr/_events.js on lines 222..226
          app/assets/javascripts/tabulatr/_events.js on lines 251..255
          app/assets/javascripts/tabulatr/_tabulatr.js on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 10 locations. Consider refactoring.
          Open

              for(var i = 0; i < tabulatr_tables.length; i++){
      if(tabulatr_tables[i].id === tableId){
        table_obj = tabulatr_tables[i];
      }
    }
          Severity: Major
          Found in app/assets/javascripts/tabulatr/_events.js and 9 other locations - About 1 hr to fix
          app/assets/javascripts/tabulatr/_events.js on lines 11..15
          app/assets/javascripts/tabulatr/_events.js on lines 57..61
          app/assets/javascripts/tabulatr/_events.js on lines 72..76
          app/assets/javascripts/tabulatr/_events.js on lines 96..100
          app/assets/javascripts/tabulatr/_events.js on lines 131..135
          app/assets/javascripts/tabulatr/_events.js on lines 166..170
          app/assets/javascripts/tabulatr/_events.js on lines 222..226
          app/assets/javascripts/tabulatr/_events.js on lines 251..255
          app/assets/javascripts/tabulatr/_tabulatr.js on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 10 locations. Consider refactoring.
          Open

            for(var i = 0; i < tabulatr_tables.length; i++){
    if(tabulatr_tables[i].id === tableId){
      table_obj = tabulatr_tables[i];
    }
  }
          Severity: Major
          Found in app/assets/javascripts/tabulatr/_events.js and 9 other locations - About 1 hr to fix
          app/assets/javascripts/tabulatr/_events.js on lines 11..15
          app/assets/javascripts/tabulatr/_events.js on lines 57..61
          app/assets/javascripts/tabulatr/_events.js on lines 72..76
          app/assets/javascripts/tabulatr/_events.js on lines 96..100
          app/assets/javascripts/tabulatr/_events.js on lines 108..112
          app/assets/javascripts/tabulatr/_events.js on lines 131..135
          app/assets/javascripts/tabulatr/_events.js on lines 166..170
          app/assets/javascripts/tabulatr/_events.js on lines 222..226
          app/assets/javascripts/tabulatr/_tabulatr.js on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 10 locations. Consider refactoring.
          Open

              for(var i = 0; i < tabulatr_tables.length; i++){
      if(tabulatr_tables[i].id === tableId){
        table_obj = tabulatr_tables[i];
      }
    }
          Severity: Major
          Found in app/assets/javascripts/tabulatr/_events.js and 9 other locations - About 1 hr to fix
          app/assets/javascripts/tabulatr/_events.js on lines 11..15
          app/assets/javascripts/tabulatr/_events.js on lines 57..61
          app/assets/javascripts/tabulatr/_events.js on lines 72..76
          app/assets/javascripts/tabulatr/_events.js on lines 108..112
          app/assets/javascripts/tabulatr/_events.js on lines 131..135
          app/assets/javascripts/tabulatr/_events.js on lines 166..170
          app/assets/javascripts/tabulatr/_events.js on lines 222..226
          app/assets/javascripts/tabulatr/_events.js on lines 251..255
          app/assets/javascripts/tabulatr/_tabulatr.js on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 10 locations. Consider refactoring.
          Open

              for(var i = 0; i < tabulatr_tables.length; i++){
      if(tabulatr_tables[i].id === tableId){
        table_obj = tabulatr_tables[i];
      }
    }
          Severity: Major
          Found in app/assets/javascripts/tabulatr/_events.js and 9 other locations - About 1 hr to fix
          app/assets/javascripts/tabulatr/_events.js on lines 11..15
          app/assets/javascripts/tabulatr/_events.js on lines 57..61
          app/assets/javascripts/tabulatr/_events.js on lines 72..76
          app/assets/javascripts/tabulatr/_events.js on lines 96..100
          app/assets/javascripts/tabulatr/_events.js on lines 108..112
          app/assets/javascripts/tabulatr/_events.js on lines 131..135
          app/assets/javascripts/tabulatr/_events.js on lines 222..226
          app/assets/javascripts/tabulatr/_events.js on lines 251..255
          app/assets/javascripts/tabulatr/_tabulatr.js on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language