mfinzi/pristine-ml

View on GitHub

Showing 97 of 97 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if(self.filt_size==1):
            a = np.array([1.,])
        elif(self.filt_size==2):
            a = np.array([1., 1.])
        elif(self.filt_size==3):
Severity: Major
Found in oil/architectures/parts/antialiasing.py and 1 other location - About 1 day to fix
oil/architectures/parts/antialiasing.py on lines 89..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 202.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if(self.filt_size == 1):
            a = np.array([1., ])
        elif(self.filt_size == 2):
            a = np.array([1., 1.])
        elif(self.filt_size == 3):
Severity: Major
Found in oil/architectures/parts/antialiasing.py and 1 other location - About 1 day to fix
oil/architectures/parts/antialiasing.py on lines 27..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 202.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _queue_management_worker has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

def _queue_management_worker(executor_reference,
                             processes,
                             pending_work_items,
                             work_ids_queue,
                             call_queue,
Severity: Minor
Found in oil/tuning/localGpuExecutor.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File localGpuExecutor.py has 410 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
#import torch.multiprocessing as multiprocessing
from concurrent import futures
import torch
torch.multiprocessing.set_start_method("spawn",force="True")#.get_context('spawn')
Severity: Minor
Found in oil/tuning/localGpuExecutor.py - About 5 hrs to fix

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/architectures/img_gen/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/parts/__init__.py on lines 0..17
    oil/architectures/pointcloud/__init__.py on lines 0..9
    oil/datasetup/__init__.py on lines 0..9
    oil/recipes/__init__.py on lines 0..9
    oil/architectures/__init__.py on lines 0..9
    oil/architectures/img_classifiers/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/architectures/pointcloud/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/img_gen/__init__.py on lines 0..9
    oil/architectures/parts/__init__.py on lines 0..17
    oil/datasetup/__init__.py on lines 0..9
    oil/recipes/__init__.py on lines 0..9
    oil/architectures/__init__.py on lines 0..9
    oil/architectures/img_classifiers/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/architectures/parts/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/img_gen/__init__.py on lines 0..9
    oil/architectures/pointcloud/__init__.py on lines 0..9
    oil/datasetup/__init__.py on lines 0..9
    oil/recipes/__init__.py on lines 0..9
    oil/architectures/__init__.py on lines 0..9
    oil/architectures/img_classifiers/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/architectures/img_classifiers/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/img_gen/__init__.py on lines 0..9
    oil/architectures/parts/__init__.py on lines 0..17
    oil/architectures/pointcloud/__init__.py on lines 0..9
    oil/datasetup/__init__.py on lines 0..9
    oil/recipes/__init__.py on lines 0..9
    oil/architectures/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/recipes/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/img_gen/__init__.py on lines 0..9
    oil/architectures/parts/__init__.py on lines 0..17
    oil/architectures/pointcloud/__init__.py on lines 0..9
    oil/datasetup/__init__.py on lines 0..9
    oil/architectures/__init__.py on lines 0..9
    oil/architectures/img_classifiers/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/datasetup/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/img_gen/__init__.py on lines 0..9
    oil/architectures/parts/__init__.py on lines 0..17
    oil/architectures/pointcloud/__init__.py on lines 0..9
    oil/recipes/__init__.py on lines 0..9
    oil/architectures/__init__.py on lines 0..9
    oil/architectures/img_classifiers/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    Severity: Major
    Found in oil/architectures/__init__.py and 6 other locations - About 5 hrs to fix
    oil/architectures/img_gen/__init__.py on lines 0..9
    oil/architectures/parts/__init__.py on lines 0..17
    oil/architectures/pointcloud/__init__.py on lines 0..9
    oil/datasetup/__init__.py on lines 0..9
    oil/recipes/__init__.py on lines 0..9
    oil/architectures/img_classifiers/__init__.py on lines 0..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function __getattr__ has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        def __getattr__(self, name):
            try:
                return super().__getattr__(name)
            except AttributeError:
                attr = getattr(self.module, name)
    Severity: Minor
    Found in oil/utils/parallel.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def get_pad_layer(pad_type):
        if(pad_type in ['refl','reflect']):
            PadLayer = nn.ReflectionPad2d
        elif(pad_type in ['repl','replicate']):
            PadLayer = nn.ReplicationPad2d
    Severity: Major
    Found in oil/architectures/parts/antialiasing.py and 1 other location - About 4 hrs to fix
    oil/architectures/parts/antialiasing.py on lines 120..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def get_pad_layer_1d(pad_type):
        if(pad_type in ['refl', 'reflect']):
            PadLayer = nn.ReflectionPad1d
        elif(pad_type in ['repl', 'replicate']):
            PadLayer = nn.ReplicationPad1d
    Severity: Major
    Found in oil/architectures/parts/antialiasing.py and 1 other location - About 4 hrs to fix
    oil/architectures/parts/antialiasing.py on lines 65..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function forward has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        def forward(self, x):
            x_shape = x.shape
            if len(x.shape)==2:
                x=x.view(x.shape[0],x.shape[1],1,1)
            if len(x.shape)==3:
    Severity: Minor
    Found in oil/architectures/parts/deconv.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function genCur has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def genCur(func, unique = True, minArgs = None):
        """ Generates a 'curried' version of a function. """
        def g(*myArgs, **myKwArgs):
            def f(*args, **kwArgs):
                if args or kwArgs:                  # some more args!
    Severity: Minor
    Found in oil/utils/utils.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __getattr__ has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        def __getattr__(self, name):
            try:
                return super().__getattr__(name)
            except AttributeError:
                attr = getattr(self.module, name)
    Severity: Minor
    Found in oil/utils/parallel.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File utils.py has 285 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import numpy as np
    import torch
    import numbers
    import time
    import torch.nn as nn
    Severity: Minor
    Found in oil/utils/utils.py - About 2 hrs to fix

      Function forward has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def forward(self, x):
      
              N,C,H,W=x.shape
              out_h=(H+2*self.padding[0]-self.kernel_size[0]+1)//self.stride[0]
              out_w=(W+2*self.padding[0]-self.kernel_size[0]+1)//self.stride[1]
      Severity: Minor
      Found in oil/architectures/parts/deconv.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function logStuff has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def logStuff(self, step, minibatch=None):
              metrics = {}
              if minibatch is not None and hasattr(self,'loss'):
                  try: metrics['Minibatch_Loss'] = self.loss(minibatch).cpu().data.numpy()
                  except (NotImplementedError, TypeError): pass
      Severity: Minor
      Found in oil/model_trainers/trainer.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language