Sign upLogin

michardy/account-hijacking-prevention

View on GitHub
Star

Showing 7 of 7 total issues

Function __calculate_sub_rating has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def __calculate_sub_rating(self, data_type, session_dat, user_dat):
        """Calculate trust score for specific subtype of user data"""
        sub_tot = 0
        if data_type in user_dat and data_type in session_dat:
            for h in user_dat[data_type]: #loop through all the user's hashed data of this type and compare it to the session
Severity: Minor
Found in hijackingprevention/api.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, db, dt, site, idt, id, combine):
Severity: Minor
Found in hijackingprevention/db_int.py - About 45 mins to fix

Function valCode has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def valCode(code, uid, sid, site, key, db):
Severity: Minor
Found in hijackingprevention/verify.py - About 45 mins to fix

Function makeCode has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def makeCode(uid, sid, site, key, db):
Severity: Minor
Found in hijackingprevention/verify.py - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

@gen.coroutine
def translator(data):
    """This function provides a second stage per user salted hasher for data that will be stored indefinitly."""
    salt = bcrypt.gensalt()
    return(bcrypt.hashpw(data, salt))
Severity: Minor
Found in modules/ip_address_checker.py and 1 other location - About 30 mins to fix
modules/fingerprint.py on lines 22..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

@gen.coroutine
def translator(data):
    """This provides a function that hashes the fingerprint a second time with a per user hash."""
    salt = bcrypt.gensalt()
    return(bcrypt.hashpw(data, salt))
Severity: Minor
Found in modules/fingerprint.py and 1 other location - About 30 mins to fix
modules/ip_address_checker.py on lines 23..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function comparer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def comparer(ses_hash, usr_hash):
    """This provides a function to compare initially hashed flight times with doubly hashed stored flight times."""
    total = 0
    kmax = 0
    for k in usr_hash.keys():
Severity: Minor
Found in modules/keystroke_dynamics.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language