Sign upLogin

michardy/account-hijacking-prevention

View on GitHub
Star

Showing 5 of 7 total issues

Function __calculate_sub_rating has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def __calculate_sub_rating(self, data_type, session_dat, user_dat):
        """Calculate trust score for specific subtype of user data"""
        sub_tot = 0
        if data_type in user_dat and data_type in session_dat:
            for h in user_dat[data_type]: #loop through all the user's hashed data of this type and compare it to the session
Severity: Minor
Found in hijackingprevention/api.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, db, dt, site, idt, id, combine):
Severity: Minor
Found in hijackingprevention/db_int.py - About 45 mins to fix

Function valCode has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def valCode(code, uid, sid, site, key, db):
Severity: Minor
Found in hijackingprevention/verify.py - About 45 mins to fix

Function makeCode has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def makeCode(uid, sid, site, key, db):
Severity: Minor
Found in hijackingprevention/verify.py - About 35 mins to fix

Function comparer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def comparer(ses_hash, usr_hash):
    """This provides a function to compare initially hashed flight times with doubly hashed stored flight times."""
    total = 0
    kmax = 0
    for k in usr_hash.keys():
Severity: Minor
Found in modules/keystroke_dynamics.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language