Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star

Showing 337 of 337 total issues

Function manageParticipation has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  dom,
  container,
  padDoc,
  subject,
  me,
Severity: Minor
Found in src/pad.js - About 45 mins to fix

    Function predicateLabelForXML has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function predicateLabelForXML (p, inverse) {
  var lab
  if (inverse) {
    // If we know an inverse predicate, use its label
    var ip = UI.store.any(p, UI.ns.owl('inverseOf'))
    Severity: Minor
    Found in src/utils.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function renderPartipants has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    UI.pad.renderPartipants = function (dom, table, padDoc, subject, me, options) {
    Severity: Minor
    Found in src/pad.js - About 45 mins to fix

      Function findAppInstances has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function findAppInstances (
  context: AuthenticationContext,
  klass: $rdf.NamedNode,
  isPublic: boolean
): Promise<AuthenticationContext> {
      Severity: Minor
      Found in src/authn/authn.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function makeACLGraphbyCombo has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        kb: $rdf.IndexedFormula,
  x: $rdf.NamedNode,
  byCombo: ComboList,
  aclDoc: $rdf.NamedNode,
  main?: boolean,
      Severity: Minor
      Found in src/acl/acl.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

            for (p in possibleProperties.dp) possible.push(kb.fromNT(p))
        Severity: Major
        Found in src/widgets/forms.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if (!b[pred][agent] || !b[pred][agent][mode]) {
              return false
            }
          Severity: Major
          Found in src/acl/acl.ts - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                          if (!b[pred][ag]) b[pred][ag] = []
            Severity: Major
            Found in src/acl/acl.ts - About 45 mins to fix

              Function makeSelectForNestedCategory has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                dom,
  kb,
  subject,
  category,
  store,
              Severity: Minor
              Found in src/widgets/forms.js - About 45 mins to fix

                Function attachmentList has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                buttons.attachmentList = function (dom, subject, div, options) {
  options = options || {}
  var doc = options.doc || subject.doc()
  if (options.modify === undefined) options.modify = true
  var modify = options.modify
                Severity: Minor
                Found in src/widgets/buttons.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function makeDescription has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  dom,
  kb,
  subject,
  predicate,
  store,
                Severity: Minor
                Found in src/widgets/forms.js - About 45 mins to fix

                  Function makeSelectForCategory has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    dom,
  kb,
  subject,
  category,
  store,
                  Severity: Minor
                  Found in src/widgets/forms.js - About 45 mins to fix

                    Function makeSelectForCategory has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    forms.makeSelectForCategory = function (
  dom,
  kb,
  subject,
  category,
                    Severity: Minor
                    Found in src/widgets/forms.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function preventBrowserDropEvents has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function preventBrowserDropEvents (document: HTMLDocument): void {
  console.log('preventBrowserDropEvents called.')
  const global: any = window
  if (typeof global !== 'undefined') {
    if (global.preventBrowserDropEventsDone) return
                    Severity: Minor
                    Found in src/acl/acl-control.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          widgets.appendForm(
        dom,
        prefContainer,
        {},
        participation,
                    Severity: Minor
                    Found in src/preferences.js and 1 other location - About 45 mins to fix
                    src/preferences.js on lines 156..166

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            widgets.appendForm(
          dom,
          prefContainer,
          {},
          sharedPreferences,
                    Severity: Minor
                    Found in src/preferences.js and 1 other location - About 45 mins to fix
                    src/preferences.js on lines 141..151

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Consider simplifying this complex logical expression.
                    Open

                          if (
        (y > ele.dataValueNT && options && options.yDecreasing) ||
        (y < ele.dataValueNT && !(options && options.yDecreasing))
      ) {
        return matrix.insertBefore(tr, ele) // return the tr
                    Severity: Major
                    Found in src/matrix.js - About 40 mins to fix

                      Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      module.exports = function (dom, kb, subject, messageStore, options) {
                      Severity: Minor
                      Found in src/chat/thread.js - About 35 mins to fix

                        Function notepad has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        UI.pad.notepad = function (dom, padDoc, subject, me, options) {
                        Severity: Minor
                        Found in src/pad.js - About 35 mins to fix

                          Function renderMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            messageTable,
  bindings,
  fresh,
  options,
  userContext
                          Severity: Minor
                          Found in src/chat/message.js - About 35 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language