Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star

Showing 337 of 337 total issues

Function callbackWS has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      function callbackWS (ws, newBase) {
        UI.authn.logInLoadProfile(createContext).then(
          _context => {
            var newPaneOptions = {
              newBase: newBase,
Severity: Major
Found in src/create.js - About 2 hrs to fix

    Function attachmentList has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    buttons.attachmentList = function (dom, subject, div, options) {
  options = options || {}
  var doc = options.doc || subject.doc()
  if (options.modify === undefined) options.modify = true
  var modify = options.modify
    Severity: Major
    Found in src/widgets/buttons.js - About 2 hrs to fix

      Function runQuery has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function runQuery (query, rows, columns, table) {
    query.running = true
    var startTime = Date.now()

    var progressMessage = doc.createElement('tr')
      Severity: Major
      Found in src/table.js - About 2 hrs to fix

        Function render has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render () {
    const container = document.createElement('div')
    container.style.maxWidth = '350px'
    container.style.minHeight = '200px'
    container.style.outline = '1px solid black'
        Severity: Major
        Found in src/widgets/peoplePicker.js - About 2 hrs to fix

          Function recordPersonalDefaults has 66 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function recordPersonalDefaults (klass, context) {
  return new Promise(function (resolve, reject) {
    authn.logInLoadPreferences(context).then(
      context => {
        if (!context.preferencesFile) {
          Severity: Major
          Found in src/preferences.js - About 2 hrs to fix

            Function newChunk has 65 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              var newChunk = function (ele, before) {
    // element of chunk being split
    var kb = UI.store
    var indent = 0
    var queueProperty = null
            Severity: Major
            Found in src/pad.js - About 2 hrs to fix

              Function uploadFiles has 65 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function uploadFiles (fetcher, files, fileBase, imageBase, successHandler) {
  for (var i = 0; files[i]; i++) {
    const f = files[i]
    console.log(
      ' dropped: Filename: ' +
              Severity: Major
              Found in src/widgets/dragAndDrop.js - About 2 hrs to fix

                Function promptForNew has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                forms.promptForNew = function (
  dom,
  kb,
  subject,
  predicate,
                Severity: Major
                Found in src/widgets/forms.js - About 2 hrs to fix

                  Function selectorPanelRefresh has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  buttons.selectorPanelRefresh = function (
  list,
  dom,
  kb,
  type,
                  Severity: Major
                  Found in src/widgets/buttons.js - About 2 hrs to fix

                    Function sendMessage has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        async function sendMessage (text) {
      var now = new Date()
      await addNewTableIfNewDay(now)

      if (!text) {
                    Severity: Major
                    Found in src/chat/infinite.js - About 2 hrs to fix

                      Function ensureOneTypeIndex has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      async function ensureOneTypeIndex (context: AuthenticationContext, isPublic: boolean): Promise<AuthenticationContext | void> {
  async function makeIndexIfNecessary (context, isPublic) {
    const relevant = isPublic ? context.publicProfile : context.preferencesFile
    const visibility = isPublic ? 'public' : 'private'
                      Severity: Major
                      Found in src/authn/authn.ts - About 2 hrs to fix

                        Function wrapper has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                        Open

                        var wrapper = function () {
  var logger = {}

  // ///////////////////////  Logging
  //
                        Severity: Minor
                        Found in src/log.js - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function turnOnInput has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function turnOnInput () {
      if (options.menuHandler && menuButton) {
        const menuOptions = {
          me,
          dom,
                        Severity: Major
                        Found in src/chat/infinite.js - About 2 hrs to fix

                          Function renderPreferencesForm has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function renderPreferencesForm (subject, klass, preferencesForm, context) {
  var prefContainer = context.dom.createElement('div')
  pad.participationObject(subject, subject.doc(), context.me).then(
    participation => {
      const dom = context.dom
                          Severity: Major
                          Found in src/preferences.js - About 2 hrs to fix

                            Function render has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              render () {
    const dropContainer = document.createElement('div')
    dropContainer.style.maxWidth = '350px'
    dropContainer.style.minHeight = '200px'
    dropContainer.style.outline = '1px solid black'
                            Severity: Major
                            Found in src/widgets/peoplePicker.js - About 2 hrs to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    function suitable (x) {
        const tail = x.uri
          .slice(0, -1)
          .split('/')
          .slice(-1)[0]
                              Severity: Major
                              Found in src/chat/dateFolder.js and 1 other location - About 2 hrs to fix
                              src/chat/dateFolder.js on lines 107..114

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 81.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    function suitable (x) {
        const tail = x.uri
          .slice(0, -1)
          .split('/')
          .slice(-1)[0]
                              Severity: Major
                              Found in src/chat/dateFolder.js and 1 other location - About 2 hrs to fix
                              src/chat/dateFolder.js on lines 47..54

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 81.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function syncTableToArray has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function syncTableToArray (table, things, createNewRow) {
  let foundOne
  let row
  let i
                              Severity: Minor
                              Found in src/utils.js - About 2 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function renderLiteralSelector has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                function renderLiteralSelector (rows, columns, column) {
    var result = doc.createElement('div')

    var textBox = doc.createElement('input')
    textBox.setAttribute('type', 'text')
                              Severity: Major
                              Found in src/table.js - About 2 hrs to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                const UI = {
  icons: require('./iconBase'),
  log: require('./log'),
  ns: require('./ns'),
  pad: require('./'),
                                Severity: Major
                                Found in src/folders.js and 1 other location - About 2 hrs to fix
                                src/create.js on lines 10..19

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 79.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language